Skip to content

Commit

Permalink
chore: temporarily disable dns tests for Node compat (#26915)
Browse files Browse the repository at this point in the history
These tests are hitting a remote server which sometimes starts failing
randomly on CI.

They need to be rewritten to use a local server and have `/etc/hosts`
setup that remaps relevants URLs.
  • Loading branch information
bartlomieju authored Nov 18, 2024
1 parent cff6e28 commit 3ba464d
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 1,475 deletions.
18 changes: 10 additions & 8 deletions tests/node_compat/config.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,12 @@
"x.txt"
],
"internet": [
"test-dns-any.js",
"test-dns-ipv4.js",
"test-dns-ipv6.js",
"test-dns.js"
// TODO(bartlomieju): temporarily disabled as these tests were hitting nodejs.org
// server. We should have a setup that hits a local server instead.
// "test-dns-any.js",
// "test-dns-ipv4.js",
// "test-dns-ipv6.js",
// "test-dns.js"
],
"parallel": [
"test-assert.js",
Expand Down Expand Up @@ -149,15 +151,15 @@
],
"fixtures/keys": ["agent1-cert.pem", "agent1-key.pem", "ca1-cert.pem"],
"internet": [
"test-dns-any.js",
// "test-dns-any.js",
"test-dns-idna2008.js",
"test-dns-ipv4.js",
"test-dns-ipv6.js",
// "test-dns-ipv4.js",
// "test-dns-ipv6.js",
"test-dns-lookup.js",
"test-dns-promises-resolve.js",
"test-dns-regress-6244.js",
"test-dns-setserver-in-callback-of-resolve4.js",
"test-dns.js",
// "test-dns.js",
"test-http-https-default-ports.js"
],
"parallel": [
Expand Down
4 changes: 4 additions & 0 deletions tests/node_compat/runner/TODO.md
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,13 @@ NOTE: This file should not be manually edited. Please edit `tests/node_compat/co
- [internet/test-dgram-multicast-set-interface-lo.js](https://github.com/nodejs/node/tree/v18.12.1/test/internet/test-dgram-multicast-set-interface-lo.js)
- [internet/test-dgram-multicast-ssm-multi-process.js](https://github.com/nodejs/node/tree/v18.12.1/test/internet/test-dgram-multicast-ssm-multi-process.js)
- [internet/test-dgram-multicast-ssmv6-multi-process.js](https://github.com/nodejs/node/tree/v18.12.1/test/internet/test-dgram-multicast-ssmv6-multi-process.js)
- [internet/test-dns-any.js](https://github.com/nodejs/node/tree/v18.12.1/test/internet/test-dns-any.js)
- [internet/test-dns-cares-domains.js](https://github.com/nodejs/node/tree/v18.12.1/test/internet/test-dns-cares-domains.js)
- [internet/test-dns-getDefaultResultOrder.js](https://github.com/nodejs/node/tree/v18.12.1/test/internet/test-dns-getDefaultResultOrder.js)
- [internet/test-dns-ipv4.js](https://github.com/nodejs/node/tree/v18.12.1/test/internet/test-dns-ipv4.js)
- [internet/test-dns-ipv6.js](https://github.com/nodejs/node/tree/v18.12.1/test/internet/test-dns-ipv6.js)
- [internet/test-dns-txt-sigsegv.js](https://github.com/nodejs/node/tree/v18.12.1/test/internet/test-dns-txt-sigsegv.js)
- [internet/test-dns.js](https://github.com/nodejs/node/tree/v18.12.1/test/internet/test-dns.js)
- [internet/test-http-dns-fail.js](https://github.com/nodejs/node/tree/v18.12.1/test/internet/test-http-dns-fail.js)
- [internet/test-http2-issue-32922.js](https://github.com/nodejs/node/tree/v18.12.1/test/internet/test-http2-issue-32922.js)
- [internet/test-https-autoselectfamily-slow-timeout.js](https://github.com/nodejs/node/tree/v18.12.1/test/internet/test-https-autoselectfamily-slow-timeout.js)
Expand Down
194 changes: 0 additions & 194 deletions tests/node_compat/test/internet/test-dns-any.js

This file was deleted.

Loading

0 comments on commit 3ba464d

Please sign in to comment.