feat: permission stack traces in ops #26758
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crowlKats
changed the title
# Conflicts: # cli/ops/bench.rs # cli/ops/testing.rs
dsherret
reviewed
Nov 12, 2024
| #[serde] | ||
| pub fn op_pledge_test_permissions( | ||
| state: &mut OpState, | ||
| #[serde] args: ChildPermissionsArg, | ||
| #[stack_trace] stack: Option<Vec<JsStackFrame>>, |
There was a problem hiding this comment.
It might be nice if we instead stored this internally in the op state then had the ability to register updates to it:
state/worker.on_stack_update(|stack| permissions_container.set_current_stack(stack));Then in the permissions container it could check what the current registred stack is. That way we don't need to pass this around so much.
| @@ -1126,16 +1136,17 @@ mod deprecated { | |||
| } | |||
| } | |||
|
|
|||
| #[op2(fast)] | |||
| #[op2(fast, reentrant)] | |||
There was a problem hiding this comment.
Why is it necessary that reentrant is on? This should not be necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.