Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update deno_doc, use prismjs, remove internal reference html generation logic #26885

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

crowlKats
Copy link
Member

No description provided.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you bury these in a non-important folder?

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how big deno_doc has been getting with all these extra dependencies. I also wonder if we should move some of this out of the binary eventually.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should minify this one too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yikes it got formatted. will ignore it from fmt. orginal is all single line

@@ -0,0 +1,1315 @@
/* PrismJS 1.29.0
https://prismjs.com/download.html#themes=prism&languages=markup+css+clike+javascript+bash+json+markdown+regex+rust+typescript */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include that it's MIT licensed?

@crowlKats
Copy link
Member Author

I wonder how big deno_doc has been getting with all these extra dependencies. I also wonder if we should move some of this out of the binary eventually.

we removed a bunch recently. ammonia was removed thinking it wasnt necessary, however tha tbroke various things, so thats just reintroducing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants