Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(emit): surface diagnostic for invalid left hand side assignment #271

Merged
merged 1 commit into from
Aug 22, 2024
Merged

fix(emit): surface diagnostic for invalid left hand side assignment #271

merged 1 commit into from
Aug 22, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Aug 22, 2024 •
edited by lucacasonato
Loading

lucacasonato
lucacasonato approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 61cc2f4 into denoland:main Aug 22, 2024
2 checks passed
@dsherret dsherret deleted the fix_diagnostic_invalid_left_hand_side_assignment branch August 22, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsherret @lucacasonato