Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: preserve camelCased SVG attributes #278

Merged
merged 2 commits into from
Sep 30, 2024
Merged

fix: preserve camelCased SVG attributes #278

merged 2 commits into from
Sep 30, 2024

Conversation

marvinhagemeister
Copy link
Contributor

When writing the precompile transform I missed to ensure that SVG attributes that are camelCased are kept that way. This PR addresses that.

Fixes denoland/deno#25810

dsherret
dsherret approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marvinhagemeister marvinhagemeister merged commit 3c5f287 into main Sep 30, 2024
2 checks passed
@marvinhagemeister marvinhagemeister deleted the precompile-svg-attr-casing branch September 30, 2024 18:09
@marvinhagemeister marvinhagemeister mentioned this pull request Sep 30, 2024
Merged
marvinhagemeister added a commit to denoland/deno that referenced this pull request Sep 30, 2024
@marvinhagemeister
fix: precompile preserve SVG camelCase attributes (#25945)
c5c1869 
See denoland/deno_ast#278

Fixes #25810
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jsx: precompile converts props to lowercase
2 participants
@marvinhagemeister @dsherret