New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: borrow_mut error in future.rs #14

Merged

dsherret merged 2 commits into denoland:main from dsherret:fix_borrow_mut_error

Jul 4, 2024

Member

dsherret commented Jul 4, 2024

No description provided.


          fix: borrow_mut error in future.rs

7bcfd30

dsherret commented

View reviewed changes

src/future.rs

@@ @@ -141,9 +139,10 @@ where @@
                           Poll::Ready(result) => {
                             inner.future_or_output = FutureOrOutput::Output(result.clone());
                             drop(inner); // stop borrow_mut
-                            let wakers = std::mem::take(
-                              &mut *self.0.child_waker_state.wakers.borrow_mut(),
-                            );

Member Author

dsherret Jul 4, 2024

I think maybe this one is the one that caused the issue? I just changed them all to use blocks to be sure because I always get bitten by this.


          bump version

242ba9b

bartlomieju approved these changes

View reviewed changes

dsherret merged commit 81324e4 into denoland:main

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet