fix: resolve eslint working directory by looking up config files #4561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing PR for now as the docs explicitly recommend extending eslint configs. We can revisit this PR later if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4487
This PR changes eslint working directory resolution based on eslint config file markers and adds support for the new
eslint.config.jsconfig fileThe previous behavior was to resolve eslint working directory based on
node_modules(or default to project root).This change should not break previous behavior since children
node_moduleswill always be accompanied bypackage.jsonin the same locations, which theale#handlers#eslint#FindConfiglooks for in the absence of an eslint config file.