Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(terraform): add snyk linter for terraform #4583

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pbnj
Copy link
Contributor

@pbnj pbnj commented Aug 9, 2023

To Do:

  • add tests
  • add docs

@pbnj pbnj marked this pull request as draft August 9, 2023 16:29
Copy link
Member

@w0rp w0rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll check again when you've finished this.

ale_linters/terraform/snyk.vim Outdated Show resolved Hide resolved
let l:opts = ale#Var(a:buffer, 'terraform_snyk_options')

if !empty(l:opts)
let l:cmd .= ale#Pad(l:opts)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ale#Pad returns an empty string if the input is empty, so you can take the condition away and put the whole command in a return statement at the end. You can write --json into the command before the other options without ale#Pad.

Copy link

stale bot commented Mar 17, 2024

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs/Issues no longer valid label Mar 17, 2024
@stale stale bot closed this Apr 22, 2024
@w0rp w0rp reopened this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PRs/Issues no longer valid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants