Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4251 --file-filter option removed for cppcheck handler #4639

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

juanmitaboada
Copy link

--file-filter option has been removed because using it prevents cppcheck from processing the file if it is in a different path

@w0rp
Copy link
Member

w0rp commented Nov 5, 2023

I'll have to have a think about this before I merge it. It's probably right.

@w0rp
Copy link
Member

w0rp commented Dec 10, 2023

Projects often have a structure such as src/*.cpp for all source files. Running cppcheck on the entire directly could be slow without a file filter, which I belive is the reason the filter is in place. I think the solution the problem here is the following:

  1. Edit the linter so it runs in a specific cwd.
  2. Keep --filte-filter and so it to a path relative to the cwd that was selected for the linter.

ALE has functions in ale#path that can be used for this purpose. You can do that and update the tests to test for it.

Thanks for looking into this!

@w0rp w0rp added this to the Version 4.0.0 milestone Dec 10, 2023
Copy link

stale bot commented Mar 17, 2024

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs/Issues no longer valid label Mar 17, 2024
@stale stale bot closed this Apr 22, 2024
@w0rp w0rp reopened this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PRs/Issues no longer valid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants