Fix/eslint cwd strategy

[ghsang]

Closes #4487

according to eslint doc

When ESLint is run on the command line, it first checks the current working directory for eslint.config.js. If that file is found, then the search stops, otherwise it checks for eslint.config.mjs. If that file is found, then the search stops, otherwise it checks for eslint.config.cjs. If none of the files are not found, it checks the parent directory for each file. This search continues until either a config file is found or the root directory is reached.

Problem

• The existing code sets the current working directory (cwd) to the directory where the closest node_modules with ESLint installed is found. In monorepo environments like pnpm workspace or yarn workspace, ESLint is typically installed only in the root node_modules, making that directory the cwd.
• This setup fails to find the ESLint configuration if it exists only within the app's internal directories.

Solution

• According to the ESLint documentation, ESLint searches for configuration files in a specific order starting from the cwd and moving up to the root directory.
• To address the issue, modify the cwd to locate the closest ESLint configuration file from the current buffer. This change allows ESLint to find the configuration file in the parent directory if it exists, adhering to the standard configuration file resolution process described in the ESLint documentation.

[w0rp]

This looks like the right thing to me. I'll go with this, and see if this breaks something for someone else. Only the JavaScript ecosystem could make configuration so complicated.

Cheers! 🍻

[emiel]

Thank you for this!