Merge pull request rails#47200 from skipkayhil/use-ad-deprecator-ille…

…gal-state Use AD.deprecator for IllegalStateError
denysnando · Jan 31, 2023 · 3cca0d5 · 3cca0d5
2 parents 77d4ce0 + d1689ef
commit 3cca0d5
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/actionpack/lib/action_dispatch.rb b/actionpack/lib/action_dispatch.rb
@@ -36,11 +36,14 @@ module Rack
 end
 
 module ActionDispatch
+  include ActiveSupport::Deprecation::DeprecatedConstantAccessor
   extend ActiveSupport::Autoload
 
-  class IllegalStateError < StandardError
+  class DeprecatedIllegalStateError < StandardError
   end
-  deprecate_constant :IllegalStateError
+  deprecate_constant "IllegalStateError", "ActionDispatch::DeprecatedIllegalStateError",
+    message: "ActionDispatch::IllegalStateError is deprecated without replacement.",
+    deprecator: ActionDispatch.deprecator
 
   class MissingController < NameError
   end

diff --git a/actionpack/test/dispatch/response_test.rb b/actionpack/test/dispatch/response_test.rb
@@ -10,6 +10,12 @@ def setup
     @response.request = ActionDispatch::Request.empty
   end
 
+  def test_illegal_state_error_is_deprecated
+    assert_deprecated(ActionDispatch.deprecator) do
+      ActionDispatch::IllegalStateError
+    end
+  end
+
   def test_can_wait_until_commit
     t = Thread.new {
       @response.await_commit