Miscellaneous small fixes #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works fine for the redis gem either way, but mock_redis before 0.20.0 (May 2019) does not flatten the array and so requires this. sds/mock_redis#147
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In the course of working on #20 , I noticed a few small fixes that could be made. This PR collects them.
Changes
The commit message for 5cf344b explains its purpose: not for the redis gem itself, but for older versions of the mock_redis gem.
Regarding 37ce088, Timecop when not used in block mode requires
Timecop.returnto be called manually to undo its effects. Otherwise its effects are global. This is easily overlooked. It might be appropriate to switch to block-only usage instead, but this commit is the smaller fix.Tests
In my local testing,
rake specstill passes.Notes
I'm the author of this work (Jamie McCarthy, @jamiemccarthy) and I'm submitting this PR under the terms of the existing LICENSE.md in this repository.