Appeals 23420 search defect

app/controllers/idt/api/v2/appeals_controller.rb

@@ -14,11 +14,11 @@ def details
     result = if docket_number?(case_search)
                CaseSearchResultsForDocketNumber.new(
                  docket_number: case_search, user: current_user
-               ).call
+               ).api_call
              else
                CaseSearchResultsForVeteranFileNumber.new(
                  file_number_or_ssn: case_search, user: current_user
-               ).call
+               ).api_call
              end
 
     render_search_results_as_json(result)

app/decorators/appeal_status_api_decorator.rb

@@ -3,6 +3,12 @@
 # Extends the Appeal model with methods for the Appeals Status API
 
 class AppealStatusApiDecorator < ApplicationDecorator
+  def initialize(appeal, scheduled_hearing = nil)
+    super(appeal)
+
+    @scheduled_hearing = scheduled_hearing
+  end
+
   def appeal_status_id
     "A#{id}"
   end
@@ -162,19 +168,19 @@ def remanded_sc_decision_issues
   end
 
   def open_pre_docket_task?
-    tasks.open.any? { |task| task.is_a?(PreDocketTask) }
+    open_tasks.any? { |task| task.is_a?(PreDocketTask) }
   end
 
   def pending_schedule_hearing_task?
-    tasks.open.where(type: ScheduleHearingTask.name).any?
+    pending_schedule_hearing_tasks.any?
   end
 
   def hearing_pending?
     scheduled_hearing.present?
   end
 
   def evidence_submission_hold_pending?
-    tasks.open.where(type: EvidenceSubmissionWindowTask.name).any?
+    evidence_submission_hold_pending_tasks.any?
   end
 
   def at_vso?

app/models/appeal.rb

@@ -308,6 +308,18 @@ def decorated_with_status
     AppealStatusApiDecorator.new(self)
   end
 
+  def open_tasks
+    tasks.open
+  end
+
+  def pending_schedule_hearing_tasks
+    tasks.open.where(type: ScheduleHearingTask.name)
+  end
+
+  def evidence_submission_hold_pending_tasks
+    tasks.open.where(type: EvidenceSubmissionWindowTask.name)
+  end
+
   # :reek:RepeatedConditionals
   def active_request_issues_or_decision_issues
     decision_issues.empty? ? active_request_issues : fetch_all_decision_issues
@@ -633,7 +645,7 @@ def direct_review_docket?
   end
 
   def active?
-    tasks.open.of_type(:RootTask).any?
+    open_tasks.of_type(:RootTask).any?
   end
 
   def ready_for_distribution?
@@ -748,7 +760,7 @@ def substitutions
   end
 
   def status
-    @status ||= BVAAppealStatus.new(appeal: self)
+    @status ||= BVAAppealStatus.new(tasks: tasks)
   end
 
   def previously_selected_for_quality_review

app/models/hearing.rb

@@ -187,12 +187,15 @@ def advance_on_docket_motion
       .first
   end
 
+  def scheduled_for
+    scheduled_for_hearing_day(hearing_day, updated_by, regional_office_timezone)
+  end
+
   # returns scheduled datetime object considering the timezones
   # @return [nil] if hearing_day is nil
   # @return [Time] in scheduled_in_timezone timezone - if scheduled_datetime and scheduled_in_timezone are present
   # @return [Time] else datetime in regional office timezone
-  # rubocop:disable Metrics/AbcSize
-  def scheduled_for
+  def scheduled_for_hearing_day(hearing_day, updated_by, regional_office_timezone)
     return nil unless hearing_day
 
     # returns datetime in scheduled_in_timezone timezone
@@ -234,7 +237,6 @@ def scheduled_for
       )
     end
   end
-  # rubocop:enable Metrics/AbcSize
 
   def scheduled_for_past?
     scheduled_for < DateTime.yesterday.in_time_zone(regional_office_timezone)

app/models/task.rb

@@ -101,7 +101,7 @@ class << self; undef_method :open; end
   # Equivalent to .reject(&:hide_from_queue_table_view) but offloads that to the database.
   scope :visible_in_queue_table_view, lambda {
     where.not(
-      type: Task.descendants.select(&:hide_from_queue_table_view).map(&:name)
+      type: hidden_task_classes
     )
   }
 
@@ -138,6 +138,10 @@ class << self
     # With taks that are likely to need Reader to complete
     READER_PRIORITY_TASK_TYPES = [JudgeAssignTask.name, JudgeDecisionReviewTask.name].freeze
 
+    def hidden_task_classes
+      Task.descendants.select(&:hide_from_queue_table_view).map(&:name)
+    end
+
     def reader_priority_task_types
       READER_PRIORITY_TASK_TYPES
     end

app/models/tasks/evidence_submission_window_task.rb

@@ -11,7 +11,7 @@ class EvidenceSubmissionWindowTask < Task
 
   before_validation :set_assignee
 
-  def initialize(args)
+  def initialize(args = {})
     @end_date = args&.fetch(:end_date, nil)
     super(args&.except(:end_date))
   end

app/services/bva_appeal_status.rb

@@ -3,7 +3,7 @@
 # Determine the BVA workflow status of an Appeal (symbol and string) based on its Tasks.
 
 class BVAAppealStatus
-  attr_reader :status
+  attr_reader :status, :tasks
 
   SORT_KEYS = {
     not_distributed: 1,
@@ -69,8 +69,18 @@ def attorney_task_names
     end
   end
 
-  def initialize(appeal:)
-    @appeal = appeal
+  Tasks = Struct.new(
+    :open,
+    :active,
+    :in_progress,
+    :cancelled,
+    :completed,
+    :assigned,
+    keyword_init: true
+  )
+
+  def initialize(tasks:)
+    @tasks = tasks
     @status = compute
   end
 
@@ -86,15 +96,12 @@ def to_i
     SORT_KEYS[status]
   end
 
-  def as_json(_args)
+  def as_json(_args = nil)
     to_sym
   end
 
   private
 
-  attr_reader :appeal
-
-  delegate :tasks, to: :appeal
   # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity, Metrics/MethodLength
   def compute
     if open_pre_docket_task?
@@ -113,7 +120,7 @@ def compute
       :ready_for_signature
     elsif active_sign_task?
       :signed
-    elsif completed_dispatch_task? && open_tasks.empty?
+    elsif completed_dispatch_task? && tasks.open.empty?
       :dispatched
     elsif completed_dispatch_task?
       :post_dispatch
@@ -133,84 +140,60 @@ def compute
   end
   # rubocop:enable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity, Metrics/MethodLength
 
-  def open_tasks
-    @open_tasks ||= tasks.open
-  end
-
-  def active_tasks
-    @active_tasks ||= tasks.active
-  end
-
-  def assigned_tasks
-    @assigned_tasks ||= tasks.assigned
-  end
-
-  def in_progress_tasks
-    @in_progress_tasks ||= tasks.in_progress
-  end
-
-  def cancelled_tasks
-    @cancelled_tasks ||= tasks.cancelled
-  end
-
-  def completed_tasks
-    @completed_tasks ||= tasks.completed
-  end
-
   def open_pre_docket_task?
-    open_tasks.any? { |task| task.is_a?(PreDocketTask) }
+    tasks.open.any? { |task| task.type == "PreDocketTask" }
   end
 
   def open_distribution_task?
-    open_tasks.any? { |task| task.is_a?(DistributionTask) }
+    tasks.open.any? { |task| task.type == "DistributionTask" }
   end
 
   def open_timed_hold_task?
-    open_tasks.any? { |task| task.is_a?(TimedHoldTask) }
+    tasks.open.any? { |task| task.type == "TimedHoldTask" }
   end
 
   def active_judge_assign_task?
-    active_tasks.any? { |task| task.is_a?(JudgeAssignTask) }
+    tasks.active.any? { |task| task.type == "JudgeAssignTask" }
   end
 
   def assigned_attorney_task?
-    assigned_tasks.any? { |task| self.class.attorney_task_names.include?(task.type) }
+    tasks.assigned.any? { |task| self.class.attorney_task_names.include?(task.type) }
   end
 
   def active_colocated_task?
-    active_tasks.any? { |task| self.class.colocated_task_names.include?(task.type) }
+    tasks.active.any? { |task| self.class.colocated_task_names.include?(task.type) }
   end
 
   def attorney_task_in_progress?
-    in_progress_tasks.any? { |task| self.class.attorney_task_names.include?(task.type) }
+    tasks.in_progress.any? { |task| self.class.attorney_task_names.include?(task.type) }
   end
 
   def active_judge_decision_review_task?
-    active_tasks.any? { |task| task.is_a?(JudgeDecisionReviewTask) }
+    tasks.active.any? { |task| task.type == "JudgeDecisionReviewTask" }
   end
 
   def active_sign_task?
-    active_tasks.any? { |task| %w[BvaDispatchTask QualityReviewTask].include?(task.type) }
+    tasks.active.any? { |task| %w[BvaDispatchTask QualityReviewTask].include?(task.type) }
   end
 
   def completed_dispatch_task?
-    completed_tasks.any? { |task| task.is_a?(BvaDispatchTask) }
+    tasks.completed.any? { |task| task.type == "BvaDispatchTask" }
   end
 
   def docket_switched?
     # TODO: this should be updated to check that there are no active tasks once the task handling is implemented
-    completed_tasks.any? { |task| task.is_a?(DocketSwitchGrantedTask) }
+    tasks.completed.any? { |task| task.type == "DocketSwitchGrantedTask" }
   end
 
   def cancelled_root_task?
-    cancelled_tasks.any? { |task| task.is_a?(RootTask) }
+    tasks.cancelled.any? { |task| task.type == "RootTask" }
   end
 
   def misc_task?
-    active_tasks.any? { |task| self.class.misc_task_names.include?(task.type) }
+    tasks.active.any? { |task| self.class.misc_task_names.include?(task.type) }
   end
 
   def active_specialty_case_team_assign_task?
-    active_tasks.any? { |task| task.is_a?(SpecialtyCaseTeamAssignTask) }
+    tasks.active.any? { |task| task.type == "SpecialtyCaseTeamAssignTask" }
   end
 end