[#190] change type to id_type in va_identifier object

department-of-veterans-affairs · Oct 7, 2020 · 304c19e · 304c19e
1 parent 0b66fe2
commit 304c19e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/app/v2/notifications/notification_schemas.py b/app/v2/notifications/notification_schemas.py
@@ -135,13 +135,13 @@
         "reference": {"type": "string"},
         "phone_number": {"type": "string", "format": "phone_number"},
         "va_identifier": {"type": "object", "properties": {
-            "type": {
+            "id_type": {
                 "type": "string"
             },
             "value": {
                 "type": "string"
             }
-        }},
+        }, "required": ["id_type", "value"]},
         "template_id": uuid,
         "personalisation": personalisation,
         "scheduled_for": {"type": ["string", "null"], "format": "datetime_within_next_day"},

diff --git a/tests/app/v2/notifications/test_notification_schemas.py b/tests/app/v2/notifications/test_notification_schemas.py
@@ -108,15 +108,15 @@ def test_get_notifications_request_invalid_statuses_and_template_types():
 }
 valid_va_identifier_json = {
     "va_identifier": {
-        "type": "foo",
+        "id_type": "foo",
         "value": "bar"
     },
     "template_id": str(uuid.uuid4())
 }
 valid_phone_number_and_va_identifier_json = {
     "phone_number": "6502532222",
     "va_identifier": {
-        "type": "foo",
+        "id_type": "foo",
         "value": "bar"
     },
     "template_id": str(uuid.uuid4())