Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade protobuf #1886

Open
3 tasks
mchlwellman opened this issue Jul 26, 2024 · 3 comments
Open
3 tasks

Upgrade protobuf #1886

mchlwellman opened this issue Jul 26, 2024 · 3 comments

Comments

@mchlwellman
Copy link

mchlwellman commented Jul 26, 2024

User Story - Business Need

The notification-api container failed to deploy after a dependency upgrade due to issues with protobuf. From the logs it looks like the issue might be with eventlet, but that needs to be investigated.

  • Ticket is understood, and QA has been contacted (if the ticket has a QA label).

User Story(ies)

As a VANotify developer
I want the latest version of protobuf
So that we minimize vulnerabilities and future upgrade pains.

Additional Info and Resources

  • According to pip (see the comment below), protobuf is required by these installed packages: ddtrace, google-api-core, googleapis-common-protos, grpcio-status, proto-plus. Of these packages, at least ddtrace is a top-level dependency.

screenshot_cropped

  • protobof is not a top level dependency, the toml file should be reviewed to see what packages use it and identify what the conflict is that created the errors.
  • once resolved, the protobuf line can be removed from the toml file.
  • Local testing did not reveal this issue, it required a deployment

Acceptance Criteria

  • notification-api deploys successfully with the latest version of protobuf
  • Update the Slide deck with the key win and a demo slide

Potential Dependencies

We should work this in parallel with ddtrace #1662

@kbelikova-oddball
Copy link

@kalbfled
Copy link
Member

$ pip show protobuf
Name: protobuf
Version: 4.25.4
Summary: 
Home-page: https://developers.google.com/protocol-buffers/
Author: [email protected]
Author-email: [email protected]
License: 3-Clause BSD License
Location: /.venv/lib/python3.10/site-packages
Requires: 
Required-by: ddtrace, google-api-core, googleapis-common-protos, grpcio-status, proto-plus

@EvanParish
Copy link

$ poetry show protobuf 
 name         : protobuf 
 version      : 4.25.4   
 description  :          

required by
 - ddtrace >=3
 - google-api-core >=3.19.5,<3.20.0 || >3.20.0,<3.20.1 || >3.20.1,<4.21.0 || >4.21.0,<4.21.1 || >4.21.1,<4.21.2 || >4.21.2,<4.21.3 || >4.21.3,<4.21.4 || >4.21.4,<4.21.5 || >4.21.5,<6.0.0.dev0
 - googleapis-common-protos >=3.20.2,<4.21.1 || >4.21.1,<4.21.2 || >4.21.2,<4.21.3 || >4.21.3,<4.21.4 || >4.21.4,<4.21.5 || >4.21.5,<6.0.0.dev0
 - grpcio-status >=4.21.6
 - proto-plus >=3.19.0,<6.0.0dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants