#1857 Dependency Update #1885
Merged
#1857 Dependency Update #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanParish
reviewed
Jul 26, 2024
pyproject.toml
Outdated
| @@ -36,6 +36,7 @@ marshmallow-sqlalchemy = "*" | |||
| nanoid = "*" | |||
| notifications-python-client = "*" | |||
| phonenumbers = "*" | |||
| protobuf = "^4.25" # TODO: Pinned because version 5.27.2 failed to deploy | |||
There was a problem hiding this comment.
Did you create a ticket to look into this issue? The ticket number should be in the TODO comment.
There was a problem hiding this comment.
^^^ please make that ticket and add the ticket number here
cris-oddball
requested changes
Jul 26, 2024
pyproject.toml
Outdated
| @@ -36,6 +36,7 @@ marshmallow-sqlalchemy = "*" | |||
| nanoid = "*" | |||
| notifications-python-client = "*" | |||
| phonenumbers = "*" | |||
| protobuf = "^4.25" # TODO: Pinned because version 5.27.2 failed to deploy | |||
There was a problem hiding this comment.
^^^ please make that ticket and add the ticket number here
cris-oddball
approved these changes
Jul 26, 2024
EvanParish
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR Is a regular dependency update. There was one failure - protobuf, which is captured in this ticket.
issue #1857
Type of change
Please check the relevant option(s).
How Has This Been Tested?
Checklist