Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation/9887-chanel-improve-monitoring-when-release-does-not-release #10168

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

IsraelleHub
Copy link
Contributor

Description of Change

The Android 2.37 and 2.38 releases never released - we need to figure out why, and fix what went wrong so it doesn't happen again.
Investigate if we can better detect and alert when a release doesn't release

Initial notes

the play store flagged/rejected a build of ours as not meeting their data policy on September 16.
we thought that rejection was on a test build, and that everything for production builds was OK
our automated slack messages kept saying everything was released (example)
On October 14, trying to follow up on if LinkWithAnalytics crash was happening in the latest Android version, we saw that firebase was showing 2.36 as the latest released version for Android
On October 15, digging in further, we realized that 2.37 and 2.38 had never been released. It appeared that after rejecting a build, we needed to manually press a button in the google play console, in order for the play store review team to start reviewing our app again, post-rejection ("send 7 changes for review" blue button in screenshot)
Pressed that button, google play approved within ~30 min, and we released 2.38 to the play store on Oct 15 at 1:37pm central time.

Screenshots/Video

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@IsraelleHub IsraelleHub self-assigned this Nov 13, 2024
@IsraelleHub IsraelleHub added devops QA and Release Label identifies this work is done on the QA and Release Team labels Nov 13, 2024
@IsraelleHub
Copy link
Contributor Author

Giving this PR comes with critical updates, I will be doing the testing of this with @narin over 2 releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops QA and Release Label identifies this work is done on the QA and Release Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant