Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/9583-EnableSSOAppWide #9673

Draft
wants to merge 75 commits into
base: develop
Choose a base branch
from
Draft

feature/9583-EnableSSOAppWide #9673

wants to merge 75 commits into from

Conversation

theodur
Copy link
Contributor

@theodur theodur commented Sep 24, 2024 •
edited
Loading

Description of Change

Enables SSO in applicable places throughout the app:

  • NotificationSettingsScreen
  • AppointmentCancelReschedule
  • NeedHelpData
  • HealthScreen (Health care application link)

Screenshots/Video

AppointmentCancelReschedule
Appointment.Schedule.After.webm
NeedHelpData
Claims.and.appeals.After.webm
NotificationSettingsScreen
Notifications.After.webm

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@theodur
Pass scope param to login page
9d1ce9f
@theodur
Add storage for device secret
53f6add
@theodur
Add device_secret type
b727be8
@theodur
Store device secret
856bd5d
@theodur
Add feature toggle for sso
db9aeb9
@theodur
Add logic to WebViewScreen for SSO authentication
ee9aeeb
@theodur
Always return NoAppointments component for testing
67ae19e
@theodur
Add feature flagged WebView
018f31d
@theodur
Update dependency array
cdc0356
@theodur
Add react-natie-cookies package
3b5545e
@theodur
Set cookies in CookieManager
f9bdd42
@theodur
Revoke SSO session on logout
0c84567
@theodur
Clear cookie manager cookies on logout
ffeddce
@theodur
Add feature togge logic to Webview SSO
39dbbf1
@theodur
Always display Webview link for testing
930b720
@theodur
Set hasSession local storage in Webview
a9d10c3
@theodur
Update loading logic
7c8e0a2
@theodur
Prevent fetching cookies if already set
c38719b
@theodur
Update logic
2502cb5
@theodur
Revert testing changes and slight refactor
2a2199e
@theodur
Merge develop
91430e5
@theodur
Fix linting errors
6ab3be4
@theodur
Mock cookies library for unit tests
fc4bcd3
@theodur
Update failing unit tests
909d780
@theodur
Merge develop
f200c1e
@theodur
Merge branch 'develop' into feature/9286-SingleSignOn
4a3de68
@theodur
Merge branch 'develop' into feature/9286-SingleSignOn
cb17a9d
@theodur
Fix cookie timeout
ac64664
@theodur
Merge branch 'develop' into feature/9286-SingleSignOn
3f31618
@theodur
Set link prefixes dynamically
7128ae0
@theodur theodur marked this pull request as ready for review October 8, 2024 04:35
@theodur theodur requested review from a team as code owners October 8, 2024 04:35
@theodur theodur requested review from timwright12, alexandec, dumathane, cadibemma and Sparowhawk and removed request for a team October 8, 2024 04:35
Base automatically changed from feature/9286-SingleSignOn to develop October 8, 2024 22:07
@dumathane dumathane added the FE-Changes Requested Requested changes from Eng or QA label Oct 15, 2024
@dumathane
Copy link
Contributor

Placing this in changes requested until we prioritize other SSO spikes/investigations.

@timwright12 timwright12 mentioned this pull request Oct 23, 2024
Open
2 tasks
@theodur theodur marked this pull request as draft October 31, 2024 19:18
@theodur theodur added the blocked Ticket is blocked and can't be worked at this time label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timwright12 timwright12 Awaiting requested review from timwright12 timwright12 is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@alexandec alexandec Awaiting requested review from alexandec alexandec is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@dumathane dumathane Awaiting requested review from dumathane dumathane is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@cadibemma cadibemma Awaiting requested review from cadibemma cadibemma is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@Sparowhawk Sparowhawk Awaiting requested review from Sparowhawk Sparowhawk is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
blocked Ticket is blocked and can't be worked at this time FE-Changes Requested Requested changes from Eng or QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theodur @dumathane @TKDickson