Feature/9763 update medication wording for va video #9888

juancstlm-a6 · 2024-10-15T19:04:23Z

Description of Change

Update the content in appointment details for the listed types to include the following component when Upcoming and Cancelled status. Existing content/wording relating to medication wording will be removed in favor of only the component listed below.

Video Atlas
Video GFE
Video Home

Screenshots/Video

Kapture.2024-10-17.at.17.12.27.mp4

Kapture.2024-10-17.at.17.16.03.mp4

iOS	Android

Testing

Tested on iOS
Tested on Android

Reviewer Validations

Update Video Atlas Appointment details to include the "Medication wording" component for Upcoming and Cancelled status
Update GFE Appointment details to include the "Medication wording" component Upcoming and Cancelled status
Update Video Home Appointment details to include the "Medication wording" component Upcoming and Cancelled status
"Medication wording" component contains a link that opens https://www.va.gov/resources/what-should-i-bring-to-my-health-care-appointments/ in a in app web view
"Medication wording" component for a Video appointment with type At Home GFE Atlas has a link to open a sheet that displays how to set up your device.
Update PrepareForVideoVisit component to include only the updated content in the screenshot above Figma
e2e Test are updated or created to cover the changes
Unit tests are updated or create to cover the changes

PR Checklist

Reviewer: Confirm the items below as you review

PR is connected to issue(s)
Tests are included to cover this change (when possible)
No magic strings (All string unions follow the Union -> Constant type pattern)
No secrets or API keys are checked in
All imports are absolute (no relative imports)
New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

juancstlm-a6 · 2024-10-17T23:55:04Z

VAMobile/e2e/tests/AppointmentsExpanded.e2e.ts

-      await expect(element(by.id('prepareForVideoVisitTestID'))).toExist()
-      await element(by.id('prepareForVideoVisitTestID')).tap()
-      await expect(element(by.text('Appointments help'))).toExist()
-      await element(by.text('Close')).tap()


This check is now part of checkMedicationWording

juancstlm-a6 · 2024-10-17T23:56:24Z

...hScreen/Appointments/UpcomingAppointments/PrepareForVideoVisit/PrepareForVideoVisit.test.tsx

-    expect(screen.getByText('Before your appointment:')).toBeTruthy()
-    expect(
-      screen.getByText(
-        'If you’re using an iPad or iPhone for your appointment, you’ll need to download the VA Video Connect iOS app beforehand. If you’re using any other device, you don’t need to download any software or app before your appointment.',
-      ),
-    ).toBeTruthy()
-    expect(
-      screen.getByText(
-        'You’ll need to have access to a web camera and microphone. You can use an external camera and microphone if your device doesn’t have one.',
-      ),
-    ).toBeTruthy()
-    expect(
-      screen.getByText(
-        /To connect to your Virtual Meeting Room at the appointment time, click the "Join session" button or the link that's in your confirmation email./,
-      ),
-    ).toBeTruthy()
-    expect(screen.getByText('To have the best possible video experience, we recommend you:')).toBeTruthy()
-    expect(
-      screen.getByText('Connect to your video appointment from a quiet, private, and well-lighted location.'),
-    ).toBeTruthy()
-    expect(
-      screen.getByText('Check to ensure you have a strong Internet connection before your appointment.'),
-    ).toBeTruthy()
-    expect(
-      screen.getByText(
-        'Connect to your appointment using a Wi-Fi network if using your mobile phone, rather than your cellular data network.',
-      ),
-    ).toBeTruthy()
-    expect(screen.getByText('Medication review:')).toBeTruthy()
-    expect(
-      screen.getByText(
-        'During your video appointment, your provider will want to review all the medications, vitamins, herbs, and supplements you’re taking—no matter if you got them from another provider, VA clinic, or local store.',
-      ),
-    ).toBeTruthy()
-    expect(
-      screen.getByText(
-        "Please be ready to talk about your medications during your video visit to ensure you're getting the best and safest care possible.",
-      ),
-    ).toBeTruthy()


Figured since most of this was changing I should update this test to use only the translation function

Sparowhawk

just the typo, but everything else seems good

...een/Appointments/AppointmentTypeComponents/SharedComponents/AppointmentMedicationWording.tsx

mistymg · 2024-10-23T17:05:35Z

Posting what I had in Slack here, too:

I noticed the iOS screenshot includes some additional wording in the 3rd bullet ("or the link that's in your confirmation email") that the Android screenshot doesn't have. Which is correct? (Videos seemed ok though.)
Wondering about your choice to include a loading component for when user goes to web view.
-If a loading component is necessary, I'd suggest more explicit wording like Loading VA.gov webpage.... The 3 periods are necessary.

Sparowhawk

all good from what I can tell, just Misty's question left about loading message for the webview is all I think needs to be addressed

juancstlm-a6 · 2024-10-23T17:57:22Z

@mistymg
Updated outdated screenshot for iOS

Updated loading copy to "Loading VA.gov webpage..."

Kapture.2024-10-23.at.10.54.40.mp4

juancstlm-a6 force-pushed the feature/9763-UPdateMedicationWordingForVAVideo branch 3 times, most recently from 17da257 to 8e74c6e Compare October 17, 2024 23:53

juancstlm-a6 commented Oct 17, 2024

View reviewed changes

juancstlm-a6 self-assigned this Oct 18, 2024

juancstlm-a6 linked an issue Oct 18, 2024 that may be closed by this pull request

Update Medication Wording for Appointments | Claim Exam #9764

Closed

5 tasks

juancstlm-a6 removed a link to an issue Oct 18, 2024

Update Medication Wording for Appointments | Claim Exam #9764

Closed

5 tasks

juancstlm-a6 linked an issue Oct 18, 2024 that may be closed by this pull request

Update Medication Wording for Appointments | VA Video #9763

Closed

9 tasks

juancstlm-a6 removed a link to an issue Oct 18, 2024

Update Medication Wording for Appointments | VA Video #9763

Closed

9 tasks

juancstlm-a6 linked an issue Oct 18, 2024 that may be closed by this pull request

Update Medication Wording for Appointments | VA Video #9763

Closed

9 tasks

juancstlm-a6 force-pushed the feature/9763-UPdateMedicationWordingForVAVideo branch 3 times, most recently from 1d4ed39 to 22deb1d Compare October 21, 2024 17:35

juancstlm-a6 marked this pull request as ready for review October 21, 2024 18:22

juancstlm-a6 requested review from a team as code owners October 21, 2024 18:22

juancstlm-a6 requested review from timwright12, alexandec, theodur, dumathane, cadibemma, Sparowhawk and DonMcCaugheyUSDS October 21, 2024 18:22

juancstlm-a6 force-pushed the feature/9763-UPdateMedicationWordingForVAVideo branch 2 times, most recently from fa68c8e to 36701e3 Compare October 22, 2024 20:13

Sparowhawk requested changes Oct 23, 2024

View reviewed changes

...een/Appointments/AppointmentTypeComponents/SharedComponents/AppointmentMedicationWording.tsx Outdated Show resolved Hide resolved

github-actions bot added the FE-Changes Requested Requested changes from Eng or QA label Oct 23, 2024

juancstlm-a6 force-pushed the feature/9763-UPdateMedicationWordingForVAVideo branch from 36701e3 to 9251bdc Compare October 23, 2024 15:35

juancstlm-a6 requested a review from Sparowhawk October 23, 2024 15:35

juancstlm-a6 force-pushed the feature/9763-UPdateMedicationWordingForVAVideo branch 3 times, most recently from e718da6 to c9ef03e Compare October 23, 2024 15:40

Sparowhawk removed the FE-Changes Requested Requested changes from Eng or QA label Oct 23, 2024

Sparowhawk previously approved these changes Oct 23, 2024

View reviewed changes

github-actions bot added the FE-With QA A PR waiting for QA Activity label Oct 23, 2024

feat: 9763 Update Medication Wording | VA Video

3c21fd0

juancstlm-a6 dismissed Sparowhawk’s stale review via 3c21fd0 October 23, 2024 17:54

juancstlm-a6 force-pushed the feature/9763-UPdateMedicationWordingForVAVideo branch from c9ef03e to 3c21fd0 Compare October 23, 2024 17:54

juancstlm-a6 requested a review from Sparowhawk October 23, 2024 17:57

TKDickson removed the FE-With QA A PR waiting for QA Activity label Oct 23, 2024

Sparowhawk approved these changes Oct 24, 2024

View reviewed changes

github-actions bot added the FE-With QA A PR waiting for QA Activity label Oct 24, 2024

TKDickson approved these changes Oct 25, 2024

View reviewed changes

github-actions bot added FE-Ready to Merge and removed FE-With QA A PR waiting for QA Activity labels Oct 25, 2024

juancstlm-a6 merged commit ba441e5 into develop Oct 25, 2024
53 of 55 checks passed

juancstlm-a6 deleted the feature/9763-UPdateMedicationWordingForVAVideo branch October 25, 2024 16:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/9763 update medication wording for va video #9888

Feature/9763 update medication wording for va video #9888

juancstlm-a6 commented Oct 15, 2024 •

edited

Loading

juancstlm-a6 Oct 17, 2024

juancstlm-a6 Oct 17, 2024

Sparowhawk left a comment

mistymg commented Oct 23, 2024

Sparowhawk left a comment

juancstlm-a6 commented Oct 23, 2024 •

edited

Loading

Feature/9763 update medication wording for va video #9888

Feature/9763 update medication wording for va video #9888

Conversation

juancstlm-a6 commented Oct 15, 2024 • edited Loading

Description of Change

Screenshots/Video

Testing

Reviewer Validations

PR Checklist

For QA

juancstlm-a6 Oct 17, 2024

Choose a reason for hiding this comment

juancstlm-a6 Oct 17, 2024

Choose a reason for hiding this comment

Sparowhawk left a comment

Choose a reason for hiding this comment

mistymg commented Oct 23, 2024

Sparowhawk left a comment

Choose a reason for hiding this comment

juancstlm-a6 commented Oct 23, 2024 • edited Loading

juancstlm-a6 commented Oct 15, 2024 •

edited

Loading

juancstlm-a6 commented Oct 23, 2024 •

edited

Loading