Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accredited Rep swagger doc fixups #14522

Merged
merged 0 commits into from
Nov 13, 2023
Merged

Accredited Rep swagger doc fixups #14522

merged 0 commits into from
Nov 13, 2023

Conversation

jvcAdHoc
Copy link
Contributor

@jvcAdHoc jvcAdHoc commented Nov 13, 2023

Summary

  • fixes the veteran_service_organization typo to veteran_service_organizations
  • lists the 200 response types as an array which should be a workaround for the ui

Related issue(s)

Testing done

  • Rendered the swaggerui locally and verified the changes

Screenshots

image

image

What areas of the site does it impact?

No impact, this pr is pure swagger docs

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@jvcAdHoc jvcAdHoc force-pushed the 69743-fixup-swagger-docs branch from 178f6b8 to 8f50116 Compare November 13, 2023 18:22
@va-vsp-bot va-vsp-bot requested a deployment to 69743-fixup-swagger-docs/main/main November 13, 2023 18:23 In progress
@jvcAdHoc jvcAdHoc marked this pull request as ready for review November 13, 2023 18:35
@jvcAdHoc jvcAdHoc requested review from a team November 13, 2023 18:35
@jvcAdHoc jvcAdHoc self-assigned this Nov 13, 2023
Copy link
Contributor

@holdenhinkle holdenhinkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jvcAdHoc jvcAdHoc merged this pull request into master Nov 13, 2023
@jvcAdHoc jvcAdHoc deleted the 69743-fixup-swagger-docs branch November 13, 2023 18:54
lindluni pushed a commit that referenced this pull request Dec 1, 2023
tsr-rise8 pushed a commit that referenced this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants