Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DR new API toggles #20669

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove DR new API toggles #20669

wants to merge 1 commit into from

Conversation

Mottie
Copy link
Contributor

@Mottie Mottie commented Feb 6, 2025

Summary

  • This work is behind a feature toggle (flipper): YES/NO

    YES

  • (Summarize the changes that have been made to the platform)

    Removing obsolete feature toggles for Decision Review new API endpoints

    • decision_review_hlr_new_api
    • decision_review_nod_new_api
    • decision_review_sc_new_api

    Dependent on these 2 PRs being merged - DO NOT MERGE BEFORE:

  • (If bug, how to reproduce)
  • (What is the solution, why is this the solution?)
  • (Which team do you work for, does your team own the maintenance of this component?)

    Benefits Decision Reviews

  • (If introducing a flipper, what is the success criteria being targeted?)

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

N/A

What areas of the site does it impact?

Decision Reviews: SC, HLR & NOD

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@Mottie Mottie added SC Supplemental Claims (Decision Reviews) NOD Notice of Disagreement (Decision Reviews) HLR Higher Level Reviews (Decision Reviews) labels Feb 6, 2025
@Mottie Mottie self-assigned this Feb 6, 2025
Copy link
Contributor

@kayline kayline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We'll need to run a DB cleanup job from the console once this merges

@Mottie Mottie marked this pull request as ready for review February 7, 2025 14:46
@Mottie Mottie requested review from a team as code owners February 7, 2025 14:46
Copy link
Contributor

@rmtolmach rmtolmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I don't see these used elsewhere in vets-api. And +1 to what Molly said. It's step 3 of this section of this guide if you need the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HLR Higher Level Reviews (Decision Reviews) NOD Notice of Disagreement (Decision Reviews) require-backend-approval SC Supplemental Claims (Decision Reviews) test-passing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants