-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS Library - Swap shared-variables import #3328
Comments
Hey team! Please add your planning poker estimate with Zenhub @Andrew565 @ataker @harshil1793 @it-harrison @jamigibbs @micahchiang @powellkerry @rsmithadhoc |
This will carry-over due to the large number of PRs that needed to be created and the difficulty in getting approvals for all of them. |
Vets-website has been updated and all PRs merged. An announcement has been made to vfs frontend devs. |
woohoo! Thanks Ian! |
Description
One of the last remaining things we need to do to get off of Formation is swap the shared-variables import that all applications use. In most instances this is a one line change that updates the import path.
There are some applications that will require variable name updates, for example: the ask-va-too app uses a
$color-gray-lightest
that css-library doesn't have, and this instead needs to be swapped tovar(--vads-color-base-lightest)
.Some applications will need additional imports from css-library because
css-library/dist/tokens/variables
no longer imports mixins and functions likeformation/shared-variables
did. For example: the caregivers application requirescss-library/dist/stylesheets/mixins
because one or more of it's partials uses this media mixin. Some applications will also need to import css-library/_functions.scss because they rely on theunits()
and/orunits-px()
function, such as several profile partials.Considerations
Tasks
~@department-of-veterans-affairs/formation/sass/shared-variables
to~@department-of-veterans-affairs/css-library/dist/tokens/variables
~@department-of-veterans-affairs/css-library/dist/stylesheets/mixins
~@department-of-veterans-affairs/css-library/dist/stylesheets/functions
Acceptance Criteria
The text was updated successfully, but these errors were encountered: