Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Library - Swap shared-variables import #3328

Closed
4 of 5 tasks
micahchiang opened this issue Oct 2, 2024 · 4 comments
Closed
4 of 5 tasks

CSS Library - Swap shared-variables import #3328

micahchiang opened this issue Oct 2, 2024 · 4 comments

Comments

@micahchiang
Copy link
Contributor

micahchiang commented Oct 2, 2024

Description

One of the last remaining things we need to do to get off of Formation is swap the shared-variables import that all applications use. In most instances this is a one line change that updates the import path.

There are some applications that will require variable name updates, for example: the ask-va-too app uses a $color-gray-lightest that css-library doesn't have, and this instead needs to be swapped to var(--vads-color-base-lightest).

Some applications will need additional imports from css-library because css-library/dist/tokens/variables no longer imports mixins and functions like formation/shared-variables did. For example: the caregivers application requires css-library/dist/stylesheets/mixins because one or more of it's partials uses this media mixin. Some applications will also need to import css-library/_functions.scss because they rely on the units() and/or units-px() function, such as several profile partials.

Considerations

  • Draft PR with all necessary updates for each application
  • Given the breadth of this work, multiple PRs may be required, it could be worthwhile to have more than 1 engineer contribute to this.

Tasks

  • Update shared-variables import path from ~@department-of-veterans-affairs/formation/sass/shared-variables to ~@department-of-veterans-affairs/css-library/dist/tokens/variables
  • Where necessary, add an import for ~@department-of-veterans-affairs/css-library/dist/stylesheets/mixins
  • Where necessary, add an import for ~@department-of-veterans-affairs/css-library/dist/stylesheets/functions
  • Test locally to ensure breakpoint styles continue to work, indicating variables are being properly read from css-library

Acceptance Criteria

  • Above tasks have been completed
@caw310
Copy link
Contributor

caw310 commented Oct 3, 2024

@it-harrison it-harrison self-assigned this Oct 11, 2024
This was referenced Oct 15, 2024
This was referenced Oct 16, 2024
@it-harrison
Copy link
Contributor

This will carry-over due to the large number of PRs that needed to be created and the difficulty in getting approvals for all of them.

@it-harrison
Copy link
Contributor

Vets-website has been updated and all PRs merged. An announcement has been made to vfs frontend devs.

@micahchiang
Copy link
Contributor Author

woohoo! Thanks Ian!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants