claims-status: swap css variable imports #32423
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerekshoe
reviewed
Oct 15, 2024
| <div className="vads-u-margin-top--2"> | ||
| This message will go away when we finish reviewing your response. | ||
| </div> | ||
| Open request: Check claim to see if action is needed from you or VA. |
There was a problem hiding this comment.
Is this change supposed to be here?
There was a problem hiding this comment.
@jerekshoe good question - I'm taking over this PR from another engineer, I will investigate!
There was a problem hiding this comment.
Flagging this so it doesn't get accidentally merged or approved until resolved.
CBonade
requested changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.
Are you removing, renaming or moving a folder in this PR?
Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the
#sitewide-public-websitesSlack channel for questions.Did you change site-wide styles, platform utilities or other infrastructure?
Summary
This PR swaps css variable imports from Formation to CSS-Library in accordance with the deprecation of Formation from vets-website
Related issue(s)
3328
Testing done
Screenshots
MHV Landing page and Messages
Profile
Combined Debt Portal
Claims Status
Facility Locator
GI
Injected Header
What areas of the site does it impact?
(Describe what parts of the site are impacted if code touched other areas)
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?