Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

header-minimal: replace disable-headings prop with enable-headings prop #32213

Merged
merged 5 commits into from
Oct 3, 2024

Conversation

powellkerry
Copy link
Contributor

@powellkerry powellkerry commented Oct 1, 2024

Are you removing, renaming or moving a folder in this PR?

  • [ x] No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

The component library has updated the va-header-minimal component to not render heading elements by default. To do this the disable-headings prop has been replaced with the enable-headings prop. This update is to adjust for that change.

Related issue(s)

department-of-veterans-affairs/vets-design-system-documentation#3097

Testing done

local testing using proxy-rewrite

Screenshots

No visual changes

What areas of the site does it impact?

Minimal header

Acceptance criteria

Quality Assurance & Testing

  • [ x] I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • [ x] No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • [ x] Linting warnings have been addressed
  • [ x] Documentation has been updated (link to documentation *if necessary)
  • [ x] Screenshot of the developed feature is added
  • [ x] Accessibility testing has been performed

Error Handling

  • [ x] Browser console contains no warnings or errors.
  • [ x] Events are being sent to the appropriate logging solution
  • [ x] Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • [ na ] Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to master/3097-minimal-header-no-heading-default/3097-minimal-header-no-heading-default October 1, 2024 21:44 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/3097-minimal-header-no-heading-default/3097-minimal-header-no-heading-default October 2, 2024 21:44 Inactive
@micahchiang micahchiang marked this pull request as ready for review October 3, 2024 17:05
@micahchiang micahchiang requested review from a team as code owners October 3, 2024 17:05
Signed-off-by: Micah Chiang <[email protected]>
@powellkerry powellkerry merged commit 877197f into main Oct 3, 2024
63 checks passed
@powellkerry powellkerry deleted the 3097-minimal-header-no-heading-default branch October 3, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants