Updating va-alert styles, prescriptions disclaimer. #4119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Closes department-of-veterans-affairs/kudos-team#269 - Related to department-of-veterans-affairs/vets.gov-designpattrns#28 Changes: - Moved Disclaimer component inside of the refills application container. - Changed rx.scss to import _m-alert partial. - Removed extraneous styles. - Deleted rx-disclaimer partial - Removed unneeded classes from Disclaimer.jsx. - Changed rx-disclaimer to va-alert.
|
Assigned to Eugene for a code review. Adding Mel and Gina, for a design review.
|
|
@webinista It looks like the bolded copy is not the same color as the icon and rest of body text. Could you make sure that is our Gray dark (#323A45)? @melwoodard Could you verify that we are using Gray dark as opposed to black? |
|
Can you check the size of the icon as well? It's a lot larger than in the mockup in department-of-veterans-affairs/vets.gov-designpattrns#28 |
|
Adjusted color and icon size.
|
|
LGTM! |
1 similar comment
|
LGTM! |
|
LGTM. @gnakm @melwoodard Is the size of the "+/-" icon okay compared to the resized alert icon? |
|
+/- should be 1.45em. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: