Adds Restclient missing exceptions

dependabot · Feb 5, 2025 · 2bf11cd · 2bf11cd
1 parent a5591fc
commit 2bf11cd
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/docker/lib/dependabot/docker/update_checker.rb b/docker/lib/dependabot/docker/update_checker.rb
@@ -211,7 +211,8 @@ def tags_from_registry
         raise if using_dockerhub?
 
         raise PrivateSourceTimedOut, registry_hostname
-      rescue RestClient::ServerBrokeConnection
+      rescue RestClient::ServerBrokeConnection,
+             RestClient::TooManyRequests
         raise PrivateSourceBadResponse, registry_hostname
       end
 

diff --git a/docker/spec/dependabot/docker/update_checker_spec.rb b/docker/spec/dependabot/docker/update_checker_spec.rb
@@ -523,6 +523,18 @@ def stub_tag_with_no_digest(tag)
             .to raise_error(Dependabot::PrivateSourceBadResponse)
         end
       end
+
+      context "when TooManyRequests request error" do
+        before do
+          stub_request(:get, repo_url + "tags/list")
+            .to_raise(RestClient::TooManyRequests)
+        end
+
+        it "raises" do
+          expect { checker.latest_version }
+            .to raise_error(Dependabot::PrivateSourceBadResponse)
+        end
+      end
     end
 
     context "when the dependency's version has a suffix" do