Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow lockfileVersion not equal to zero #11417

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Allow lockfileVersion not equal to zero #11417

merged 2 commits into from
Jan 27, 2025
+78 −2

Conversation

markhallen
Copy link
Contributor

@markhallen markhallen commented Jan 27, 2025 •
edited
Loading

What are you trying to accomplish?

bun.lock files generated by [email protected] will have a lockfileVersion value 1.

Part of #6528

Support for lockfileVersion = 1 was requested here and here.

How will you know you've accomplished your goal?

We will be able to generate dependabot PRs when the lockfileVersion value is 1.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@markhallen markhallen requested a review from a team as a code owner January 27, 2025 12:52
@markhallen
Copy link
Contributor Author

FYI @Sija and @RiskyMH

@markhallen markhallen enabled auto-merge January 27, 2025 14:18
@markhallen markhallen merged commit 645c250 into main Jan 27, 2025
66 checks passed
@markhallen markhallen deleted the markhallen/allow-locfileversion-not-equal-to-zero branch January 27, 2025 15:20
dylan-conway
dylan-conway reviewed Jan 28, 2025
View reviewed changes
Copy link

@dylan-conway dylan-conway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylan-conway dylan-conway dylan-conway left review comments

@amazimbe amazimbe amazimbe approved these changes

Assignees
No one assigned
Labels
L: javascript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markhallen @amazimbe @dylan-conway