-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Misconfigured Dependabot for PNPM Workspaces #11487
Merged
kbukum1
merged 6 commits into
main
from
kamil/handle_miss_configured_dependabot_for_pnpm_workspaces
Feb 5, 2025
Merged
Handle Misconfigured Dependabot for PNPM Workspaces #11487
kbukum1
merged 6 commits into
main
from
kamil/handle_miss_configured_dependabot_for_pnpm_workspaces
Feb 5, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34e340a
to
a2cdb5d
Compare
abdulapopoola
approved these changes
Feb 5, 2025
1 task
MaSpeng
added a commit
to skriptfabrik/n8n-nodes
that referenced
this pull request
Feb 10, 2025
As of this PR: dependabot/dependabot-core#11487 its discouraged to configure subdirectories in a pnpm workspace scenario.
MaSpeng
added a commit
to skriptfabrik/n8n-nodes
that referenced
this pull request
Feb 10, 2025
As of this PR: dependabot/dependabot-core#11487 its discouraged to configure subdirectories in a pnpm workspace scenario.
MaSpeng
added a commit
to skriptfabrik/n8n-nodes
that referenced
this pull request
Feb 10, 2025
As of this PR: dependabot/dependabot-core#11487 its discouraged to configure subdirectories in a pnpm workspace scenario.
MaSpeng
added a commit
to skriptfabrik/n8n-nodes
that referenced
this pull request
Feb 10, 2025
As of this PR: dependabot/dependabot-core#11487 its discouraged to configure subdirectories in a pnpm workspace scenario.
MaSpeng
added a commit
to skriptfabrik/n8n-nodes
that referenced
this pull request
Feb 10, 2025
As of this PR: dependabot/dependabot-core#11487 its discouraged to configure subdirectories in a pnpm workspace scenario.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This PR ensures Dependabot correctly detects and prevents updates from inside PNPM workspace subdirectories when a workspace root update is already configured.
Why?
pnpm-workspace.yaml
andpnpm-lock.yaml
exist.MisconfiguredTooling
error when:pnpm-workspace.yaml
exists in a parent directory (../pnpm-workspace.yaml
)pnpm-lock.yaml
exists in a parent directory (../pnpm-lock.yaml
)What issues does this affect or fix?
This resolves incorrect Dependabot behavior where updates are attempted from workspace subdirectories instead of the root, causing no change errors.
Anything you want to highlight for special attention from reviewers?
pnpm-workspace.yaml
andpnpm-lock.yaml
are in a parent directory trigger an error./some-project
instead of/
) will not raise errors.pnpm-workspace.yaml
orpnpm-lock.yaml
is found in the parent directory, the update proceeds normally.✅ Proper Configuration:
If you are using PNPM workspaces, you should only define the root directory (
/
) independabot.yml
. Dependabot will automatically update dependencies across all workspaces from there.❌ Misconfigured Dependabot:
If you define subdirectories (
/client
,/server
, etc.) separately, Dependabot may attempt to run updates inside a workspace subdirectory, which is not supported and will trigger an error.How will you know you've accomplished your goal?
MisconfiguredTooling
when bothpnpm-workspace.yaml
andpnpm-lock.yaml
are in a parent directory.Checklist