-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Namespace Structure and Fix Abstractions for Lockfile and Fetcher #11528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7e040d7
to
b6209d2
Compare
ef609f4
to
ae683da
Compare
javascript/lib/dependabot/javascript/shared/file_updater/package_json_preparer.rb
Dismissed
Show dismissed
Hide dismissed
javascript/lib/dependabot/javascript/shared/update_checker/registry_finder.rb
Dismissed
Show dismissed
Hide dismissed
96b557e
to
30fb6c6
Compare
On this branch I successfully ran:
Dry run output
|
markhallen
reviewed
Feb 10, 2025
javascript/lib/dependabot/javascript/bun/file_parser/bun_lock.rb
Outdated
Show resolved
Hide resolved
javascript/lib/dependabot/javascript/bun/file_parser/lockfile_parser.rb
Outdated
Show resolved
Hide resolved
javascript/lib/dependabot/javascript/bun/update_checker/conflicting_dependency_resolver.rb
Outdated
Show resolved
Hide resolved
javascript/lib/dependabot/javascript/shared/dependency_files_filterer.rb
Outdated
Show resolved
Hide resolved
javascript/lib/dependabot/javascript/shared/file_fetcher_helper.rb
Outdated
Show resolved
Hide resolved
markhallen
reviewed
Feb 10, 2025
javascript/lib/dependabot/javascript/bun/update_checker/conflicting_dependency_resolver.rb
Outdated
Show resolved
Hide resolved
markhallen
previously approved these changes
Feb 10, 2025
4d499f5
to
48e7695
Compare
48e7695
to
6277dea
Compare
markhallen
previously approved these changes
Feb 10, 2025
237b487
to
0b29712
Compare
0b29712
to
16546ef
Compare
markhallen
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This PR refactors the namespace structure and introduces necessary abstractions to improve maintainability, consistency, and clarity in Dependabot’s architecture.
🔹 Key Changes:
Dependabot::{Language}::Shared
.Dependabot::{Language}::{PackageManager}
.📂 Updated Folder & Namespace Structure:
🔹 Additional Refactors
Introduced
LockfileBase
abstractionBunLock
was directly referenced in shared files.LockfileBase
, ensuring modularity and scalability.Refactored Fetcher to use
FileFetcherBase
Bun
was referenced in shared fetchers.FileFetcherBase
, keeping shared code modular.🔹 Anything you want to highlight for special attention from reviewers?
LockfileBase
) ensuring modular lockfile parsing.🔹 How will you know you've accomplished your goal?
LockfileBase
andFileFetcherBase
abstractions.📌 Checklist