Create DATA_DIR constant that is pulled from env var #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdangerx
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
non-blocking: If I wanted to change DATA_DIR or somesuch could I put that in local.env?
There was a problem hiding this comment.
In the .env file!
| @@ -91,7 +90,7 @@ def _remove_intro( | |||
| return paragraphs[idx:] | |||
| raise ValueError("Could not find starting state") | |||
|
|
|||
| def _parse_values(self, text: str) -> None: | |||
| def _parse_values(self, text: str) -> None: # noqa: C901 | |||
There was a problem hiding this comment.
non-blocking: it might be worth pulling each section handler out into its own function, then using match/case or a dictionary to handle dispatch based on each section.
Are the sections always in a specific order? Or can they be a random jumble?
There was a problem hiding this comment.
Hmm I'm not sure tbh. Trenton did this integration way back when. I think this is something to revisit when we update the data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
"/app/data"references with a constant that pulls a path from an env var defined in.env.env