Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Symfony] Rename deploy:env to deploy:env:optimize #3932

Closed
wants to merge 1 commit into from

Conversation

richardhj
Copy link
Contributor

due to a naming conflict

This PR renames a task thats name is already used in the deploy.php (even though the task name was not used Symfony recipes before).

@@ -64,7 +64,7 @@
});

desc('Optimize environment variables');
task('deploy:env', function () {
task('deploy:env:optimize', function () {
Copy link

@Seb33300 Seb33300 Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not using the same word as the command?

Suggested change
task('deploy:env:optimize', function () {
task('deploy:env:dump', function () {

@mrhackcz
Copy link
Contributor

And what about running this task after deploy:vendors ? :)

@richardhj
Copy link
Contributor Author

And what about running this task after deploy:vendors ? :)

It is not intended to add this command to the default task at all (IMHO, because it depends on symfony/flex).
The case it ran for you was because you have had it in the deploy task (due to the bad naming) :)

@YetiCGN
Copy link

YetiCGN commented Oct 23, 2024

It is not intended to add this command to the default task at all (IMHO, because it depends on symfony/flex). The case it ran for you was because you have had it in the deploy task (due to the bad naming) :)

Nah, it was added to the deploy:prepare common workflow which is causing us problems.

@antonmedv
Copy link
Member

I will release a new version with a fix.

@antonmedv antonmedv closed this Oct 23, 2024
@richardhj
Copy link
Contributor Author

Thank you @antonmedv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants