Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added writable_acl_groups option to acl mode in deploy:writable #3957

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Added writable_acl_groups option to acl mode in deploy:writable #3957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e3bc42
Added `writable_acl_groups` option to acl mode in `deploy:writable`
null93 Nov 20, 2024
dd7ad61
Added docs
null93 Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion docs/recipe/deploy/writable.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,20 @@ The chmod mode.
```


### writable_acl_groups
[Source](https://github.com/deployphp/deployer/blob/master/recipe/deploy/writable.php#L62)

List of additional groups to give write permission to.

```php title="Default value"
[]
```


## Tasks

### deploy\:writable {#deploy-writable}
[Source](https://github.com/deployphp/deployer/blob/master/recipe/deploy/writable.php#L62)
[Source](https://github.com/deployphp/deployer/blob/master/recipe/deploy/writable.php#L65)

Makes writable dirs.

Expand Down
18 changes: 14 additions & 4 deletions recipe/deploy/writable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@
// The chmod mode.
set('writable_chmod_mode', '0755');

// List of additional groups to give write permission to.
set('writable_acl_groups', []);

desc('Makes writable dirs');
task('deploy:writable', function () {
$dirs = join(' ', get('writable_dirs'));
Expand Down Expand Up @@ -103,6 +106,13 @@
run("$sudo chmod +a \"$remoteUser allow delete,write,append,file_inherit,directory_inherit\" $dirs");
} elseif (commandExist('setfacl')) {
$setFaclUsers = "-m u:\"$httpUser\":rwX";
$setFaclGroups = "";
foreach (get("writable_acl_groups") as $index => $group) {
if ($index > 0) {
$setFaclGroups .= " ";
}
$setFaclGroups .= "-m g:\"$group\":rwX";
}
// Check if remote user exists, before adding it to setfacl
$remoteUserExists = test("id -u $remoteUser &>/dev/null 2>&1 || exit 0");
if ($remoteUserExists === true) {
Expand All @@ -119,13 +129,13 @@
$hasfacl = run("getfacl -p $dir | grep \"^user:$httpUser:.*w\" | wc -l");
// Set ACL for directory if it has not been set before
if (!$hasfacl) {
run("setfacl -L $recursive $setFaclUsers $dir");
run("setfacl -dL $recursive $setFaclUsers $dir");
run("setfacl -L $recursive $setFaclUsers $setFaclGroups $dir");
run("setfacl -dL $recursive $setFaclUsers $setFaclGroups $dir");
}
}
} else {
run("$sudo setfacl -L $recursive $setFaclUsers $dirs");
run("$sudo setfacl -dL $recursive $setFaclUsers $dirs");
run("$sudo setfacl -L $recursive $setFaclUsers $setFaclGroups $dirs");
run("$sudo setfacl -dL $recursive $setFaclUsers $setFaclGroups $dirs");
}
} else {
$alias = currentHost()->getAlias();
Expand Down
Loading