Feat/#726 profile view #757
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do-hyun-Kim
reviewed
Mar 2, 2025
| return PostReactor(postId: postId) | ||
| } | ||
|
|
||
| return .init(postId: "null") |
There was a problem hiding this comment.
podtId μ΄κΈ°κ°μΌλ‘ nullμ μ μλ 건κ°μ?
| } | ||
| } | ||
|
|
||
| func doDeepLink() { |
There was a problem hiding this comment.
DeepLinkHandlerμ μ μΈλdoDeepLink λ©μλλ DeepLinkProtocolμ μ μΈλ doDeepLink λ λ€μ΄λ°μ΄ κ²Ήμ³μ λμ€μ μ°ΎκΈ° νλ€ κ² κ°μλ° λ€λ₯΄κ² μ μΈνλ 건 μ΄λ€κ°μ?
| } | ||
|
|
||
| private func openMission() { | ||
| popToMain() |
There was a problem hiding this comment.
μκΈ° openMission μΈλ° popToMainμ΄λΌ λμ΄ μλκ±°λ μ‘°κΈ ν·κ°λ¦΄ κ² κ°μλ° pushToMission μΌλ‘ νλ 건 μ΄λ€κ°μ?
| pathComponents: [String] | ||
| ) { | ||
| if pathComponents.first == "profile", | ||
| let memberId = pathComponents[safe: 1] { |
There was a problem hiding this comment.
μκΈ° index Out Bounds γ±γ
?
- μ΄λ»κ² μ€λμ§ μμΈν λͺ¨λ₯΄κ² μ§λ§ (
.firstIndex(where: $0. == "" )) ν΄μ μΈλ±μ€ μ‘°ν ν΄μ νλκ±° μ΄λ€κ°μ©?
|
|
||
| private let style: Style | ||
|
|
||
| public var rx: Reactive<BBProfile> { |
There was a problem hiding this comment.
μ΄ rxλ μ΄λμ μ°μ΄λ 건κ°μ©??
| extension Reactive where Base: BBProfile { | ||
| var configure: Binder<BBProfile.Configure> { | ||
| return Binder(base) { view, config in | ||
| view.imageView.rx.configure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π΅PRμ μ¬λ¦¬κΈ° μ μλ μ¬νμ νμΈν΄μ£ΌμΈμ.
(μμ±μ€)
π½κ°μ
π οΈμμ λ΄μ©
(μμ λͺ©)
(μμ λͺ©)
π‘μ°¨ν κ³ν (Optional)
πΎμ΄λ―Έμ§ (Optional)
β ν μ€νΈ μΌμ΄μ€
ππ»μλμ κ°μ΄ PRμ 리뷰ν΄μ£ΌμΈμ.