[FEAT/#35] BottomSheet 구현 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mnseo
approved these changes
Jan 15, 2024
Comment on lines
32
to
38
|
|
||
| private fun initBottomSheet() { | ||
| communityList.addAll(arrayOf("직장인", "학생", "취업준비생")) | ||
|
|
||
| val listener: (String) -> Unit = { item -> | ||
| viewModel.updateCommunity(item) | ||
| bottomSheet?.dismiss() |
There was a problem hiding this comment.
요기 하드 코딩을 필요시에는 data class로 빼거나 resource로 관리하면 좋을것 같다는 생각이 듭니다 🫡
unam98
approved these changes
Jan 15, 2024
| } | ||
|
|
||
| private inline fun <reified T : Fragment> navigateTo() { | ||
| binding.btnNext.isEnabled = false | ||
| inline fun <reified T : Fragment> navigateTo() { |
Comment on lines
202
to
203
| if (_signUpProgress.value == SignUpProgress.CurrentJob && _community.value == "직장인" | ||
| || _signUpProgress.value == SignUpProgress.ReadyJob && _community.value == "취업준비생") |
There was a problem hiding this comment.
조건문이 길어져 가독성이 떨어지는 것 같은데 각각을 BooleanType local 변수로 선언해서 넣어보는 건 어떨까요?
There was a problem hiding this comment.
좋아요! 아래 코멘트 함께 반영해 수정했습니다 🙃
Comment on lines
95
to
99
| jobDetailClassBottomSheet = SingleModalBottomSheet.newInstance("직군 입력", jobDetailList, jobDetailClassListener) | ||
| jobDetailClassBottomSheet?.setFocusedImageView(ivShowWhat) | ||
| jobDetailClassBottomSheet?.setSelectedItem(viewModel.jobDetailClass.value) | ||
| jobDetailClassBottomSheet?.show(childFragmentManager, SingleModalBottomSheet.TAG) | ||
| ivShowWhat.setImageResource(R.drawable.ic_arrow_up_l) |
There was a problem hiding this comment.
apply 함수 써보면 가독성에 좋을 것 같아요
Comment on lines
+7
to
+11
| <data> | ||
| <variable | ||
| name="vm" | ||
| type="com.teumteum.teumteum.presentation.signup.SignUpViewModel" /> | ||
| </data> |
There was a problem hiding this comment.
그으랬나요?... BindingFragment에 DataBindingUtil 사용되어 있어서 일단 적용하긴 했습니담 기억이 잘 .. ㅠㅠ
unam98
reviewed
Jan 15, 2024
| && _community.value == COMMUNITY_WORKER | ||
| val isTraineeInReadyJob = _signUpProgress.value == SignUpProgress.ReadyJob | ||
| && _community.value == COMMUNITY_TRAINEE | ||
| if (isWorkerInCurrentJob || isTraineeInReadyJob) _currentStep.value++ |
|
왕 진짜 짱 멋져요 우리팀 짱 😆 🤍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요
✨ 작업 내용
✨ PR 포인트
📸 스크린샷/동영상
단일 바텀시트
bottomsheet-single-1.mp4
bottomsheet-single-2.mp4
지역선택 바텀시트
bottomsheet-area.mp4
MBTI 선택 바텀시트
bottomsheet-mbti.mp4