feat(my-recruit): 내 공고 뽀각 페이지 api 연결 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qkrdmstlr3
requested review from
woo-jk,
Collection50 and
eunbeann
as code owners
❌ Deploy Preview for bbogak failed.
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Comment on lines
12
to
27
| function getAllRecruits() { | ||
| return http.get({ url: '/recruits' }); | ||
| } | ||
|
|
||
| function getRecruitsBySeason({ season }: Request) { | ||
| return http.get({ url: '/recruits/bySeason', params: { season } }); | ||
| } | ||
|
|
||
| export function useGetAllRecruits({ season }: Request) { | ||
| const result = useSuspenseQuery({ | ||
| queryKey: [GET_RECRUITS, season], | ||
| queryFn: season === ALL_RECRUITMENT ? getAllRecruits : () => getRecruitsBySeason({ season }), | ||
| }); | ||
|
|
||
| return result.data as unknown as Response; | ||
| } |
There was a problem hiding this comment.
useDeleteRecruit.ts에 있는 함수랑 선언 방법을 통일하면 좋을 것 같아요
| export const GET_RECRUITS = 'recruits'; | ||
|
|
||
| function getAllRecruits() { | ||
| return http.get({ url: '/recruits' }); |
There was a problem hiding this comment.
Suggested change
| return http.get({ url: '/recruits' }); | |
| return http.get<Response>({ url: '/recruits' }); |
이렇게 사용하면 tanstack-query의 반환값 타입을 명시하지 않아도 가능해요
| @@ -1,3 +1,4 @@ | |||
| import { match } from 'ts-pattern'; | |||
Comment on lines
+31
to
+34
| const rightMarkBackgroundColorClassName = match({ isOutOfDate, highlighted }) | ||
| .with({ isOutOfDate: true }, () => 'bg-neutral-10') | ||
| .with({ highlighted: true }, () => 'bg-mint-40') | ||
| .otherwise(() => 'bg-neutral-95'); |
Comment on lines
+7
to
+35
| export function useResizeObserver(onResize: OnResize) { | ||
| const ref = useRef<HTMLDivElement | null>(null); | ||
| const resizeCallback = usePreservedCallback(onResize); | ||
|
|
||
| useIsomorphicLayoutEffect(() => { | ||
| let rAF = 0; | ||
|
|
||
| if (ref.current) { | ||
| const resizeObserver = new ResizeObserver((entries) => { | ||
| if (entries[0] != null) { | ||
| cancelAnimationFrame(rAF); | ||
|
|
||
| rAF = requestAnimationFrame(() => resizeCallback(entries[0])); | ||
| } | ||
| }); | ||
|
|
||
| resizeObserver.observe(ref.current); | ||
|
|
||
| return () => { | ||
| cancelAnimationFrame(rAF); | ||
| if (ref.current != null) { | ||
| resizeObserver.unobserve(ref.current); | ||
| } | ||
| }; | ||
| } | ||
| }, [resizeCallback]); | ||
|
|
||
| return ref; | ||
| } |
Comment on lines
+12
to
+34
| export const AnimateHeight = forwardRef<HTMLDivElement, AnimateHeightProps>(function AnimateHeight({ children }, ref) { | ||
| const [updated, setUpdated] = useState(false); | ||
| const heightMotionValue = useMotionValue(-1); | ||
|
|
||
| const resizeRef = useResizeObserver(({ contentRect }) => { | ||
| if (updated === false) { | ||
| setUpdated(true); | ||
| // heightMotionValue.set(contentRect.height); | ||
| return; | ||
| } | ||
| heightMotionValue.set(contentRect.height); | ||
| // animate(heightMotionValue, contentRect.height, { duration: 0.7 }); | ||
| }); | ||
|
|
||
| return ( | ||
| <motion.div | ||
| ref={ref} | ||
| style={{ maxHeight: updated ? heightMotionValue : 'auto', overflow: 'hidden' }} | ||
| transition={{ duration: 1 }}> | ||
| <div ref={resizeRef}>{children}</div> | ||
| </motion.div> | ||
| ); | ||
| }); |
| <BoxCard | ||
| key={`${cardInfo.season}-${cardInfo.title}`} | ||
| {...cardInfo} | ||
| onDuedateAppend={() => {}} |
qkrdmstlr3
changed the title
eunbeann
pushed a commit
that referenced
this pull request
Aug 25, 2024
* feat(my-recruit): 내정보뽀각 페이지 api 연결 * update * save * save
eunbeann
pushed a commit
that referenced
this pull request
Aug 25, 2024
* feat(my-recruit): 내정보뽀각 페이지 api 연결 * update * save * save
eunbeann
pushed a commit
that referenced
this pull request
Aug 26, 2024
* feat(my-recruit): 내정보뽀각 페이지 api 연결 * update * save * save
eunbeann
pushed a commit
that referenced
this pull request
Aug 26, 2024
* feat(my-recruit): 내정보뽀각 페이지 api 연결 * update * save * save
eunbeann
pushed a commit
that referenced
this pull request
Aug 26, 2024
* feat(my-recruit): 내정보뽀각 페이지 api 연결 * update * save * save
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3. 관련 스크린샷을 첨부해주세요.
4. 완료 사항
5. 추가 사항 / 코드 리뷰 받고 싶은 부분