Skip to content

Commit

Permalink
Merge pull request #430 from depromeet/bugfix/429
Browse files Browse the repository at this point in the history
회고 분석의 badPoints에 대한 옵셔널 체이닝 처리
  • Loading branch information
klmhyeonwoo authored Mar 3, 2025
2 parents f008858 + ec7d6fd commit ce85aac
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ export const RetrospectAnalysisPage = () => {
let pendingPeopleCnt = 0;

if (spaceInfo && data) {
// TODO: 로직을 어떻게 픽스해야할지 서버 개발자들이랑 같이 이야기를 해보아야 함
// spaceInfo.memberCount : 스페이스에 들어와있는 멤버 수
// data.individuals.length : 현재 해당 회고에 대한 질문 답변 수
pendingPeopleCnt = spaceInfo.memberCount - data.individuals.length;
}

Expand Down
12 changes: 6 additions & 6 deletions apps/web/src/component/retrospect/analysis/Analysis.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,9 @@ export function AnalysisContainer({ spaceId, retrospectId, hasAIAnalyzed }: Anal
)}
{selectedTab === "personal" && (
<>
{data?.individualAnalyze.badPoints == null &&
data?.individualAnalyze.goodPoints == null &&
data?.individualAnalyze.improvementPoints == null ? (
{data?.individualAnalyze?.badPoints == null &&
data?.individualAnalyze?.goodPoints == null &&
data?.individualAnalyze?.improvementPoints == null ? (
<EmptyList
message={
<>
Expand All @@ -142,13 +142,13 @@ export function AnalysisContainer({ spaceId, retrospectId, hasAIAnalyzed }: Anal
/>
) : (
<>
{data?.individualAnalyze.goodPoints && (
{data?.individualAnalyze?.goodPoints && (
<InsightsBoxSection type="goodPoints" insightArr={data.individualAnalyze.goodPoints} isTeam={false} />
)}
{data?.individualAnalyze.badPoints && (
{data?.individualAnalyze?.badPoints && (
<InsightsBoxSection type="badPoints" insightArr={data.individualAnalyze.badPoints} isTeam={false} />
)}
{data?.individualAnalyze.improvementPoints && (
{data?.individualAnalyze?.improvementPoints && (
<InsightsBoxSection type="improvementPoints" insightArr={data.individualAnalyze.improvementPoints} isTeam={false} />
)}
</>
Expand Down

0 comments on commit ce85aac

Please sign in to comment.