Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge to Main #425

Merged
merged 24 commits into from
Nov 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
9c7c61f
Merge pull request #407 from depromeet/fix/route
raymondanythings Sep 18, 2024
0eceea9
fix: #410 Modify Nickname Placeholder
klmhyeonwoo Sep 24, 2024
e44851c
Merge pull request #411 from depromeet/bugfix/410/fixNickNamePlaceHolder
klmhyeonwoo Sep 24, 2024
b5dd5dc
fix: #409 Add Prevent External(Inapp) Browser Logic
klmhyeonwoo Sep 24, 2024
872c20f
Merge pull request #412 from depromeet/bugfix/409/AddPreventExternalBโ€ฆ
klmhyeonwoo Oct 29, 2024
db11cc9
fix: #349 firefox textarea height ๋„˜์น  ๋•Œ ์ˆ˜์ •
leeminhee119 Oct 29, 2024
3b7daf9
Merge pull request #415 from depromeet/fix/330/input-tipcard-gap
leeminhee119 Oct 30, 2024
e83ec52
feat: #416 ์ฑ„๋„ํ†ก ์—ฐ๋™, ๋งˆ์ดํŽ˜์ด์ง€์—๋งŒ ๋œจ๋„๋ก
leeminhee119 Oct 31, 2024
944badc
fix: #416 ๋งˆ์ดํŽ˜์ด์ง€ ํ•˜์œ„ ๋ชจ๋“  ํŽ˜์ด์ง€์— ์ฑ„๋„ํ†ก ๋ฒ„ํŠผ ๋…ธ์ถœ
leeminhee119 Oct 31, 2024
07417c0
Merge pull request #417 from depromeet/feat/416/channel-talk
leeminhee119 Nov 2, 2024
b4cf4a2
fix: #409 ์›น ํ™˜๊ฒฝ์—์„œ ์นด์นด์˜ค ๋ธŒ๋ผ์šฐ์ € ๋กœ๊ทธ์ธ ์‹œ, ์†Œ์…œ ๋กœ๊ทธ์ธ ์ •์ฑ… ์šฐํšŒ
klmhyeonwoo Nov 3, 2024
0487e44
fix: #409 ์ž˜๋ชป๋œ ์ฝ”๋“œ ์ˆœ์„œ ๋ณ€๊ฒฝ
klmhyeonwoo Nov 3, 2024
f1dec8c
Merge pull request #419 from depromeet/bugfix/409/externalBrowser
klmhyeonwoo Nov 4, 2024
4b4c420
chore: #420 ๊ณต์ง€ ์ปดํฌ๋„ŒํŠธ ๋‚ด๋ถ€๋กœ ๋ฐ”ํ…€์‹œํŠธ ์ด๋™
leeminhee119 Nov 8, 2024
6a32566
chore: #420 1109 ๊ณต์ง€ (์ธํ”„๋ผ ์ด์ „) ์ถ”๊ฐ€
leeminhee119 Nov 8, 2024
3aef83c
chore: #420 ์ด๋ฉ”์ผ ๋ณต์‚ฌ ๊ธฐ๋Šฅ ์ถ”๊ฐ€
leeminhee119 Nov 8, 2024
5a6f728
Merge pull request #422 from depromeet/chore/420/announce1109
leeminhee119 Nov 9, 2024
b40731c
chore: #420 ์ด๋ฉ”์ผ -> ์ฑ„๋„ํ†ก์œผ๋กœ ๋ณ€๊ฒฝ
leeminhee119 Nov 9, 2024
73ca940
chore: #420 ๋งˆ์ดํŽ˜์ด์ง€ -> ๋‚ด์ •๋ณดํŽ˜์ด์ง€
leeminhee119 Nov 9, 2024
04f1bcf
chore: #420 ์‚ฌ์šฉํ•˜์ง€ ์•Š๋Š” ํ•จ์ˆ˜ ์ œ๊ฑฐ
leeminhee119 Nov 9, 2024
ba23bd7
fix: #409 ์นด์นด์˜ค ์ธ์•ฑ ๋ธŒ๋ผ์šฐ์ €์—์„œ๋„ ์„œ๋น„์Šค ํ™”๋ฉด ๊ทธ๋Œ€๋กœ ๋„์šฐ๋„๋ก ์žฌ์ˆ˜์ •
klmhyeonwoo Nov 9, 2024
aa286fe
chore: #420 ์ฑ„๋„ํ†ก ๋ชจ๋“  ํŽ˜์ด์ง€๋กœ ์ž„์‹œ ์ด๋™, ๋ฐ”ํ…€์‹œํŠธ z-index ์ˆ˜์ •
leeminhee119 Nov 9, 2024
f909eb8
Merge pull request #423 from depromeet/chore/420/announce1109
leeminhee119 Nov 9, 2024
c09d1d9
Merge pull request #424 from depromeet/bugfix/409/externalBrowser
klmhyeonwoo Nov 9, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion apps/web/src/app.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ ReactDOM.createRoot(document.getElementById("root")!).render(
<Suspense fallback={<LoadingModal purpose={"๋ฐ์ดํ„ฐ๋ฅผ ๊ฐ€์ ธ์˜ค๊ณ  ์žˆ์–ด์š”"} />}>
{/* <ReactQueryDevtools initialIsOpen={false} /> */}
{/* <DevTools /> */}

<Routers />
<Toast />
</Suspense>
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/app/login/SetNicknamePage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export function SetNickNamePage() {
<Spacing size={0.3} />
<Typography variant="T4">๋‹‰๋„ค์ž„์„ ์„ค์ •ํ•ด์ฃผ์„ธ์š”!</Typography>
<Spacing size={4} />
<Input value={nickName} onChange={handleInputChange} placeholder="Text" count={true} maxLength={maxLength} />
<Input value={nickName} onChange={handleInputChange} placeholder="๋‹‰๋„ค์ž„์„ ์ž…๋ ฅํ•ด์ฃผ์„ธ์š”" count={true} maxLength={maxLength} />
<Spacing size={3.6} />
<TipCard message={"์‹ค๋ช…์œผ๋กœ ํ™œ๋™ํ•˜๋Š” ๊ฑธ ์ถ”์ฒœํ•ด์š”!"} />

Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/component/BottomSheet/BottomSheet.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export function BottomSheet({ id, title, contents, handler = false, quitButton =
border-top-right-radius: 1.6rem;
box-shadow: 0 4rem 4rem rgba(0, 0, 0, 0.25);
transition: transform 200ms ease-out;
z-index: 10001;
z-index: 100000000;
padding: 2rem;
box-sizing: border-box;
background-color: #fff;
Expand Down
69 changes: 69 additions & 0 deletions apps/web/src/component/announcement/Announcement.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
import { css } from "@emotion/react";
import Cookies from "js-cookie";

import { BottomSheet } from "@/component/BottomSheet";
import { ButtonProvider } from "@/component/common/button";
import { Icon } from "@/component/common/Icon";
import { Typography } from "@/component/common/typography";

type AnnouncementProps = { title: string; content: React.ReactNode; onConfirm: () => void; sheetId: string };

export function Announcement({ title, content, onConfirm, sheetId }: AnnouncementProps) {
const SHOW_ANNOUNCEMENT_KEY = "announcement-checked";

const hideAnnouncement = Cookies.get(SHOW_ANNOUNCEMENT_KEY);

if (hideAnnouncement) return;

return (
<BottomSheet
sheetHeight={620}
id={sheetId}
contents={
<div
css={css`
display: flex;
flex-direction: column;
align-items: center;
gap: 2rem;
overflow: hidden;
height: 100%;
`}
>
<div
css={css`
display: flex;
flex-direction: column;
align-items: center;
gap: 1.6rem;
`}
>
<Icon icon={"ic_letter"} size={4.8} />
<Typography variant={"title18Bold"} color={"gray900"}>
{title}
</Typography>
</div>
<div
css={css`
overflow-y: auto;
::-webkit-scrollbar {
display: block;
}
`}
>
{content}
</div>

<ButtonProvider.Primary
onClick={() => {
Cookies.set(SHOW_ANNOUNCEMENT_KEY, new Date().toISOString(), { expires: 1 });
onConfirm();
}}
>
ํ™•์ธ
</ButtonProvider.Primary>
</div>
}
/>
);
}
48 changes: 0 additions & 48 deletions apps/web/src/component/common/announcement/Announcement.tsx

This file was deleted.

1 change: 1 addition & 0 deletions apps/web/src/component/common/input/TextArea.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ export const TextArea = forwardRef<HTMLTextAreaElement, TextAreaProps>(function
id={id || textareaContext?.id}
css={css`
flex-grow: 1;
overflow: auto;
::placeholder {
color: ${DESIGN_TOKEN_COLOR["gray500"]};
${DESIGN_TOKEN_TEXT["body15Medium"]}
Expand Down
18 changes: 18 additions & 0 deletions apps/web/src/helper/preventExternalBrowser.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import { Fragment, PropsWithChildren } from "react";

export function PreventExternalBrowser({ children }: PropsWithChildren) {
const agent = navigator.userAgent;
const URL = document.URL;
const isKakao = agent.includes("KAKAO");
const isInstagram = agent.includes("Instagram");

if (isKakao) {
window.open(`kakaotalk://web/openExternal?url=${encodeURIComponent(URL)}`);
} else if (isInstagram) {
/**
* NOTE: ํ˜„์žฌ๋Š” ํ•ด๋‹น ์ธ์Šคํƒ€๊ทธ๋žจ ์ธ์•ฑ ํƒˆ์ถœ ์ฝ”๋“œ๊ฐ€ ์ž‘๋™ํ•˜์ง€ ์•Š๋Š” ๊ฒƒ ๊ฐ™์Œ
* ์ถ”ํ›„ ์นด์นด์˜คํ†ก์ฒ˜๋Ÿผ ์ธ์Šคํƒ€๊ทธ๋žจ ์ธ์•ฑ ๋ฐฉ์ง€ ๋ถ„์„ ํ›„ ์ฝ”๋“œ ์ถ”๊ฐ€ ์˜ˆ์ •
*/
}
return <Fragment> {children} </Fragment>;
}
82 changes: 81 additions & 1 deletion apps/web/src/layout/GlobalLayout.tsx
Original file line number Diff line number Diff line change
@@ -1,21 +1,40 @@
import { css } from "@emotion/react";
import Hotjar from "@hotjar/browser";
// import { PATHS } from "@layer/shared";
import { useEffect } from "react";
import { Outlet } from "react-router-dom";
// import { useLocation } from "react-router-dom";

import { Announcement } from "@/component/announcement/Announcement";
import { Modal } from "@/component/common/Modal";
import { Typography } from "@/component/common/typography";
import { PreventExternalBrowser } from "@/helper/preventExternalBrowser.tsx";
import { useBottomSheet } from "@/hooks/useBottomSheet";
// import ChannelService from "@/lib/channel-talk/service";
import { useBridge } from "@/lib/provider/bridge-provider";

const siteId = import.meta.env.VITE_HOTJAR_KEY as number;
const hotjarVersion = import.meta.env.VITE_HOTJAR_VERSION as number;
const SHEET_ID = "announcement";

export default function GlobalLayout() {
const { safeAreaHeight } = useBridge();
const { openBottomSheet, closeBottomSheet } = useBottomSheet();

useEffect(() => {
Hotjar.init(siteId, hotjarVersion);
openBottomSheet({ id: SHEET_ID });
}, []);

/* NOTE - ์ธํ”„๋ผ ์ด์ „ ๊ธฐ๊ฐ„๋™์•ˆ ์ฑ„๋„ํ†ก ๋ชจ๋“  ํŽ˜์ด์ง€ ๋…ธ์ถœ */
// useEffect(() => {
// if (location.pathname.startsWith(PATHS.myInfo())) {
// ChannelService.showChannelButton();
// } else {
// ChannelService.hideChannelButton();
// }
// }, [location]);

return (
<div
css={css`
Expand All @@ -35,8 +54,69 @@ export default function GlobalLayout() {
${safeAreaHeight && { height: `calc(100dvh-${safeAreaHeight * 2}px)` }}
`}
>
<Announcement
sheetId={SHEET_ID}
onConfirm={closeBottomSheet}
title="์ธํ”„๋ผ ์ด์ „ ์•ˆ๋‚ด"
content={
<>
<Typography
variant={"body16Medium"}
color={"gray600"}
css={css`
white-space: pre-wrap;
`}
>
{`์•ˆ๋…•ํ•˜์„ธ์š”, ๋ ˆ์ด์–ด ์„œ๋น„์Šค์ž…๋‹ˆ๋‹ค.
ํ•ญ์ƒ ์ €ํฌ ์„œ๋น„์Šค๋ฅผ ์ด์šฉํ•ด ์ฃผ์…”์„œ ๊ฐ์‚ฌ๋“œ๋ฆฝ๋‹ˆ๋‹ค.

์„œ๋น„์Šค ํ’ˆ์งˆ ํ–ฅ์ƒ์„ ์œ„ํ•œ ์ธํ”„๋ผ ์ด์ „์„ ์ง„ํ–‰ํ•˜๊ณ ์ž ํ•˜์˜ค๋‹ˆ ์ž ์‹œ ์–‘ํ•ด๋ฅผ ๋ถ€ํƒ๋“œ๋ฆฝ๋‹ˆ๋‹ค.
์ž‘์—… ์ง„ํ–‰ ์‹œ๊ฐ„ ๋™์•ˆ ์„œ๋น„์Šค๊ฐ€ ์ ‘์†์ด ๋˜์ง€ ์•Š๊ฑฐ๋‚˜ ๋Š๋ ค์ง€๋Š” ํ˜„์ƒ์ด ์žˆ์„ ์ˆ˜ ์žˆ์œผ๋‹ˆ ์ด์šฉ์— ์ฐธ๊ณ ํ•˜์‹œ๊ธฐ ๋ฐ”๋ž๋‹ˆ๋‹ค.

1. ์ ๊ฒ€ ์‹œ๊ฐ„

`}
</Typography>
<Typography variant={"subtitle16SemiBold"}>2024๋…„ 11์›” 10์ผ(์ผ) 13:00 ~ 22:00</Typography>
<Typography
variant={"body16Medium"}
color={"gray600"}
css={css`
white-space: pre-wrap;
`}
>
{`
โ€ป ๋ชจ๋“  ์‹œ๊ฐ„์€ ํ•œ๊ตญ์‹œ๊ฐ„ ๊ธฐ์ค€์ž…๋‹ˆ๋‹ค.
โ€ป ์ž‘์—… ์ง„ํ–‰์ƒํ™ฉ์— ๋”ฐ๋ผ ์ผ์ •์€ ๋ณ€๊ฒฝ๋  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.

2. ๋Œ€์ƒ ์„œ๋น„์Šค

๋ ˆ์ด์–ด ์„œ๋น„์Šค

ํ•ด๋‹น ๊ธฐ๊ฐ„๋™์•ˆ ๊ถ๊ธˆํ•˜์‹  ์ ์€ `}
</Typography>
<Typography variant={"subtitle16SemiBold"}>ํŽ˜์ด์ง€ ํ•˜๋‹จ์˜ ๋ฌธ์˜ํ•˜๊ธฐ</Typography>
<Typography
variant={"body16Medium"}
color={"gray600"}
css={css`
white-space: pre-wrap;
`}
>
{`๋ฅผ ํ†ตํ•ด ์ฑ„ํŒ… ๋‚จ๊ฒจ์ฃผ์‹œ๋ฉด ๋น ๋ฅด๊ฒŒ ํ™•์ธ ํ›„ ์ˆœ์ฐจ์ ์œผ๋กœ ๋‹ต๋ณ€ ๋“œ๋ฆฌ๊ฒ ์Šต๋‹ˆ๋‹ค.

์ด์šฉ์— ๋ถˆํŽธ์„ ๋“œ๋ ค ์ฃ„์†กํ•ฉ๋‹ˆ๋‹ค.
๋ณด๋‹ค ์•ˆ์ •์ ์ธ ์„œ๋น„์Šค๋ฅผ ์ œ๊ณตํ•˜๊ธฐ ์œ„ํ•ด ๋…ธ๋ ฅํ•˜๋Š” ๋ ˆ์ด์–ด๊ฐ€ ๋˜๊ฒ ์Šต๋‹ˆ๋‹ค.

๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค.`}
</Typography>
</>
}
/>
<Modal />
<Outlet />
<PreventExternalBrowser>
<Outlet />
</PreventExternalBrowser>
</div>
);
}
Loading
Loading