Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: FAQ 컴포넌트 test-case 작성 #338

Merged
merged 1 commit into from
Jan 14, 2024

Conversation

kimyouknow
Copy link
Member

@kimyouknow kimyouknow commented Jan 7, 2024

작업 내용

제곧내

좀 더 고민해보고 pr 열게요~

스크린샷

사용 방법

레퍼런스

#335

Copy link

vercel bot commented Jan 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
www-depromeet-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2024 3:16pm

Copy link

github-actions bot commented Jan 7, 2024

Bundle Sizes

Compared against 842c9ee

Route: No significant changes found

Dynamic import: None found.

@kimyouknow kimyouknow marked this pull request as ready for review January 8, 2024 15:19
@kimyouknow kimyouknow added the refactor refactoring code or performance label Jan 8, 2024
@kimyouknow kimyouknow merged commit cebfa8a into base/faq-refactor Jan 14, 2024
9 checks passed
@kimyouknow kimyouknow deleted the feat/faq-tc branch January 14, 2024 05:17
kimyouknow added a commit that referenced this pull request Feb 18, 2024
* [chore]: vitest + @testing-library 세팅 (#336)

* chore: vscode 기본 세팅

- explicit - Triggers Code Actions when explicitly saved. Same as true.
- https://code.visualstudio.com/updates/v1_85#_code-actions-on-save-and-auto

* chore: vitest 관련 라이브러리 설치

* chore: vitest 세팅

* feat: vitest Provider

* feat: formatSingleDigit vitest  잘 돌아가나 확인용 tc

* feat: vitest + react 잘 돌아가나 FAQ 컴포넌트  tc 작성

* [refactor]: formatSingleDigit 선행 조건 강화 및 테스트 코드 수정 (#337)

* feat: 테스트 케이스 추가

* feat: formatSingleDigit 선행조건 강화

* refactor: 음수 및 정수가 아닌 숫자 에러처리

* fix: infinity 관련 tc 추가

* [chore]: FAQ 컴포넌트 test-case 작성 (#338)

chore: faq - tc

* feat: FAQ 컴포넌트 테스트 코드 작성 (#339)

* refactor: 컴포넌트 aria-label 추가 및 시맨틱 태그 부여

* feat: faq 컴포넌트 테스트 코드 작성

* chore: 스토리북 props

* feat: [지원자격] 탭 활성 description 수정 및 테스트 세분화

* refactor: 답변이 보이는 질문 리스트 셀렉터 수정

* feat: 세부구현~
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor refactoring code or performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant