Skip to content

Commit

Permalink
Fix oidc cypress test and remove doc link
Browse files Browse the repository at this point in the history
Signed-off-by: Derek Ho <[email protected]>
  • Loading branch information
derek-ho committed Apr 30, 2024
1 parent 1a261d9 commit 16d1269
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion server/auth/types/authentication_type.ts
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,6 @@ export abstract class AuthenticationType implements IAuthenticationType {
let cookie: SecuritySessionCookie | null | undefined;
let authInfo: any | undefined;
// if this is an REST API call, suppose the request includes necessary auth header
// see https://www.elastic.co/guide/en/opensearch-dashboards/master/using-api.html
if (this.requestIncludesAuthInfo(request)) {
try {
const additionalAuthHeader = await this.getAdditionalAuthHeader(request);
Expand Down
2 changes: 1 addition & 1 deletion test/cypress/e2e/oidc/oidc_auth_test.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ describe('Log in via OIDC', () => {

cy.visit('http://localhost:5601/app/dev_tools#/console');

cy.get('a').contains('Dev Tools').should('be.visible');
cy.get('a[data-test-subj="breadcrumb first last"]').contains('Dev Tools').should('be.visible');

cy.getCookie('security_authentication').should('exist');
});
Expand Down

0 comments on commit 16d1269

Please sign in to comment.