Skip to content

Commit

Permalink
make the bar look nice
Browse files Browse the repository at this point in the history
Signed-off-by: Derek Ho <[email protected]>
  • Loading branch information
derek-ho committed Dec 7, 2023
1 parent 150c55d commit 6a0f5c4
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
8 changes: 6 additions & 2 deletions public/apps/configuration/utils/password-edit-panel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

import React from 'react';
import { CoreStart } from 'opensearch-dashboards/public';
import { EuiFieldText, EuiIcon } from '@elastic/eui';
import { EuiFieldText, EuiFlexGroup, EuiFlexItem, EuiIcon } from '@elastic/eui';
import { FormRow } from './form-row';
import { PASSWORD_INSTRUCTION } from '../../apps-constants';
import { getDashboardsInfo } from '../../../utils/dashboards-info-utils';
Expand Down Expand Up @@ -63,6 +63,8 @@ export function PasswordEditPanel(props: {

Check failure on line 63 in public/apps/configuration/utils/password-edit-panel.tsx

View workflow job for this annotation

GitHub Actions / Run unit tests (ubuntu-latest)

Delete `โŽ`

Check failure on line 63 in public/apps/configuration/utils/password-edit-panel.tsx

View workflow job for this annotation

GitHub Actions / Run unit tests (macos-latest)

Delete `โŽ`

Check failure on line 63 in public/apps/configuration/utils/password-edit-panel.tsx

View workflow job for this annotation

GitHub Actions / Run unit tests (windows-latest)

Delete `โโŽ`
return (
<>
<EuiFlexGroup direction='row'>

Check failure on line 66 in public/apps/configuration/utils/password-edit-panel.tsx

View workflow job for this annotation

GitHub Actions / Run unit tests (ubuntu-latest)

Replace `ยทยทยทยท<EuiFlexGroupยทdirection='row'` with `ยทยทยทยทยทยท<EuiFlexGroupยทdirection="row"`

Check failure on line 66 in public/apps/configuration/utils/password-edit-panel.tsx

View workflow job for this annotation

GitHub Actions / Run unit tests (macos-latest)

Replace `ยทยทยทยท<EuiFlexGroupยทdirection='row'` with `ยทยทยทยทยทยท<EuiFlexGroupยทdirection="row"`

Check failure on line 66 in public/apps/configuration/utils/password-edit-panel.tsx

View workflow job for this annotation

GitHub Actions / Run unit tests (windows-latest)

Replace `ยทยทยทยท<EuiFlexGroupยทdirection='row'` with `ยทยทยทยทยทยท<EuiFlexGroupยทdirection="row"`
<EuiFlexItem grow={false}>

Check failure on line 67 in public/apps/configuration/utils/password-edit-panel.tsx

View workflow job for this annotation

GitHub Actions / Run unit tests (ubuntu-latest)

Insert `ยทยท`

Check failure on line 67 in public/apps/configuration/utils/password-edit-panel.tsx

View workflow job for this annotation

GitHub Actions / Run unit tests (macos-latest)

Insert `ยทยท`

Check failure on line 67 in public/apps/configuration/utils/password-edit-panel.tsx

View workflow job for this annotation

GitHub Actions / Run unit tests (windows-latest)

Insert `ยทยท`
<FormRow headerText="Password" helpText={passwordHelpText}>

Check failure on line 68 in public/apps/configuration/utils/password-edit-panel.tsx

View workflow job for this annotation

GitHub Actions / Run unit tests (ubuntu-latest)

Replace `ยทยทยทยทยทยท` with `ยทยทยทยทยทยทยทยทยทยท`

Check failure on line 68 in public/apps/configuration/utils/password-edit-panel.tsx

View workflow job for this annotation

GitHub Actions / Run unit tests (macos-latest)

Replace `ยทยทยทยทยทยท` with `ยทยทยทยทยทยทยทยทยทยท`

Check failure on line 68 in public/apps/configuration/utils/password-edit-panel.tsx

View workflow job for this annotation

GitHub Actions / Run unit tests (windows-latest)

Replace `ยทยทยทยทยทยท` with `ยทยทยทยทยทยทยทยทยทยท`
<EuiFieldText

Check failure on line 69 in public/apps/configuration/utils/password-edit-panel.tsx

View workflow job for this annotation

GitHub Actions / Run unit tests (ubuntu-latest)

Insert `ยทยทยทยท`

Check failure on line 69 in public/apps/configuration/utils/password-edit-panel.tsx

View workflow job for this annotation

GitHub Actions / Run unit tests (macos-latest)

Insert `ยทยทยทยท`

Check failure on line 69 in public/apps/configuration/utils/password-edit-panel.tsx

View workflow job for this annotation

GitHub Actions / Run unit tests (windows-latest)

Insert `ยทยทยทยท`
data-test-subj="password"

Check failure on line 70 in public/apps/configuration/utils/password-edit-panel.tsx

View workflow job for this annotation

GitHub Actions / Run unit tests (ubuntu-latest)

Insert `ยทยทยทยท`

Check failure on line 70 in public/apps/configuration/utils/password-edit-panel.tsx

View workflow job for this annotation

GitHub Actions / Run unit tests (macos-latest)

Insert `ยทยทยทยท`

Check failure on line 70 in public/apps/configuration/utils/password-edit-panel.tsx

View workflow job for this annotation

GitHub Actions / Run unit tests (windows-latest)

Insert `ยทยทยทยท`
Expand All @@ -71,8 +73,10 @@ export function PasswordEditPanel(props: {
onChange={passwordChangeHandler}

Check failure on line 73 in public/apps/configuration/utils/password-edit-panel.tsx

View workflow job for this annotation

GitHub Actions / Run unit tests (ubuntu-latest)

Insert `ยทยทยทยท`

Check failure on line 73 in public/apps/configuration/utils/password-edit-panel.tsx

View workflow job for this annotation

GitHub Actions / Run unit tests (macos-latest)

Insert `ยทยทยทยท`

Check failure on line 73 in public/apps/configuration/utils/password-edit-panel.tsx

View workflow job for this annotation

GitHub Actions / Run unit tests (windows-latest)

Replace `ยทยทยทยทยทยทยทยทยทยท` with `ยทยทยทยทยทยทยทยทยทยทยทยทยทยท`
/>

Check failure on line 74 in public/apps/configuration/utils/password-edit-panel.tsx

View workflow job for this annotation

GitHub Actions / Run unit tests (ubuntu-latest)

Replace `ยทยทยทยทยทยทยทยท` with `ยทยทยทยทยทยทยทยทยทยทยทยท`

Check failure on line 74 in public/apps/configuration/utils/password-edit-panel.tsx

View workflow job for this annotation

GitHub Actions / Run unit tests (macos-latest)

Replace `ยทยทยทยทยทยทยทยท` with `ยทยทยทยทยทยทยทยทยทยทยทยท`

Check failure on line 74 in public/apps/configuration/utils/password-edit-panel.tsx

View workflow job for this annotation

GitHub Actions / Run unit tests (windows-latest)

Replace `ยทยทยทยทยทยทยทยท` with `ยทยทยทยทยทยทยทยทยทยทยทยท`
</FormRow>

{password && <PasswordStrengthBar password={password}/>}
</EuiFlexItem>
</EuiFlexGroup>

<FormRow
headerText="Re-enter password"
Expand Down
2 changes: 1 addition & 1 deletion public/apps/configuration/utils/password-strength-bar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export const PasswordStrengthBar = (props: PasswordStrengthBarProps) => {
</EuiText>
</EuiFlexItem>
<EuiFlexItem>
<EuiProgress value={strength} max={4} size="s" />
<EuiProgress value={strength} max={4} size="m" />
</EuiFlexItem>
</EuiFlexGroup>
)
Expand Down

0 comments on commit 6a0f5c4

Please sign in to comment.