Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to PHPStan2 #363

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Upgrade to PHPStan2 #363

merged 1 commit into from
Dec 19, 2024

Conversation

dereuromark
Copy link
Owner

@dereuromark dereuromark commented Nov 17, 2024

Some PHPStan issues that are not fixable or need Cake 5.1.2 core patch (revert list<> nonsense).

Error: Parameter #1 $message of method Cake\Console\ConsoleIo::verbose() expects list<string>|string, array<string>|string given.
Error: Parameter #1 $message of method Cake\Console\ConsoleIo::quiet() expects list<string>|string, array<string>|string given.
Error: Parameter #1 $message of method Cake\Console\ConsoleIo::out() expects list<string>|string, array<string>|string given.
Error: Parameter #1 $message of method Cake\Console\ConsoleIo::err() expects list<string>|string, array<string> given.
Error: Parameter #1 $message of method Cake\Console\ConsoleIo::err() expects list<string>|string, array<string> given.

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.73%. Comparing base (8c1c1cf) to head (d5c687b).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #363   +/-   ##
=========================================
  Coverage     83.73%   83.73%           
  Complexity     1847     1847           
=========================================
  Files           116      116           
  Lines          5079     5079           
=========================================
  Hits           4253     4253           
  Misses          826      826           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereuromark dereuromark merged commit 69bfae7 into master Dec 19, 2024
8 checks passed
@dereuromark dereuromark deleted the phpstan2 branch December 19, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants