Fix reloading of quickly changing files #635
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derf
reviewed
Jan 3, 2022
zsugabubus
force-pushed
the
fix-reload
branch
2 times, most recently
from
42ad5fe
to
53746b0
Compare
When file changes on disk, Imlib2's compares cached and actual file time with second granularity (as returned by __imlib_FileModDate()). When we do forced reloading, it can be assumed that file has surely changed externally (not caring about file times) so Imlib2's cache should be ignored.
zsugabubus
force-pushed
the
fix-reload
branch
from
53746b0
to
1680407
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fehmisses some reloads when file is changing too fast.