Improve zooming feature with logarithmic scale #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent idea! I would still like a separate slow-zoom mode, but this is great. |
|
Okay, so I've added another option called While |
myQwil
force-pushed
the
natural-zoom
branch
2 times, most recently
from
db83b2f
to
10d838e
Compare
|
Thank you for making this better 😄 |
myQwil
changed the title
Zooming now uses a logarithmic scale, and the events for zooming in/out gravitate to powers of 2, such as 50%, 100%, 200%, etc. The option `--zoom-step` has been changed to represent the number of zoom steps between powers of 2, with the default being 3 steps.
While `--zoom-steps` is the number of button or key presses between powers of 2, `--zoom-rate` represents the number of pixels between powers of 2 that the user clicks and drags between, so if you added the arg `--zoom-rate=1024`, it would result in a very slow zoom mode. The default is 128 pixels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zoom-mode now zooms on a logarithmic scale, and the events for zooming in/out gravitate to powers of 2, such as 50%, 100%, 200%, etc.
The option
--zoom-stephas been changed to represent the number of zoom steps between powers of 2, with the default being 3 steps.The number of zoom steps is optional, while the rate of zoom-mode uses a constant rate that is not affected by zoom steps.
Edit: You can also step between powers other than 2. For example, if you want 5 steps between powers of 3, you would enter the raw value of
ln(2) / ln(3) * 5which results in:--zoom-step=3.154648768