Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.8.1 #55

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Version 0.8.1 #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26af4a4
Remove validation for OAuth native clientId in iOS plugin
shilgapira Feb 29, 2024
89147e3
Update for release
shilgapira Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# 0.8.1

- Remove OAuth `clientId` validation in iOS plugin

# 0.8.0

- Add custom attributes and multiple names to DescopeUser objects
Expand Down
5 changes: 0 additions & 5 deletions ios/Classes/DescopePlugin.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,9 @@ public class DescopePlugin: NSObject, FlutterPlugin, FlutterStreamHandler {

private func oauthNative(call: FlutterMethodCall, result: @escaping FlutterResult) {
guard let args = call.arguments as? [String: Any] else { return result(FlutterError(code: "MISSINGARGS", message: "Unexpected empty arguments in oauthNative", details: nil)) }
guard let clientId = args["clientId"] as? String else { return result(FlutterError(code: "MISSINGARGS", message: "'clientId' is required for oauthNative", details: nil)) }
guard let nonce = args["nonce"] as? String else { return result(FlutterError(code: "MISSINGARGS", message: "'nonce' is required for oauthNative", details: nil)) }
guard let implicit = args["implicit"] as? Bool else { return result(FlutterError(code: "MISSINGARGS", message: "'implicit' is required for oauthNative", details: nil)) }

if clientId != Bundle.main.bundleIdentifier {
return result(FlutterError(code: "FAILED", message: "OAuth provider clientId doesn't match bundle identifier", details: nil))
}

Task { @MainActor in
do {
let authorization = try await performAuthorization(nonce: nonce)
Expand Down
2 changes: 1 addition & 1 deletion lib/src/sdk/sdk.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class DescopeSdk {
static const name = 'DescopeFlutter';

/// The Descope SDK version
static const version = '0.8.0';
static const version = '0.8.1';

/// The configuration of the [DescopeSdk] instance.
final DescopeConfig config;
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: descope
description: A Flutter package for working with the Descope API.
version: 0.8.0
version: 0.8.1
homepage: https://www.descope.com
repository: https://github.com/descope/descope-flutter
issue_tracker: https://github.com/descope/descope-flutter/issues
Expand Down