chore: update prettier config, run format #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taesungh
reviewed
Jul 31, 2024
| "tabWidth": 4, | ||
| "useTabs": true, | ||
| "printWidth": 80, |
There was a problem hiding this comment.
Suggestion: I think many previous lines were formatted at print width around 88 which does help prevent some overly compact lines.
| "semi": true, | ||
| "singleQuote": false, | ||
| "printWidth": 80 | ||
| "plugins": ["@ianvs/prettier-plugin-sort-imports"], |
There was a problem hiding this comment.
Question: is there a particular reason you chose a plugin for Prettier rather than something like eslint-plugin-import which is included in eslint-config-react-app?
Comment on lines
+14
to
+21
| "^~/types/(.*)$", | ||
| "^~/config/(.*)$", | ||
| "^~/lib/(.*)$", | ||
| "^~/hooks/(.*)$", | ||
| "^~/components/ui/(.*)$", | ||
| "^~/components/(.*)$", | ||
| "^~/styles/(.*)$", | ||
| "^~/app/(.*)$", |
There was a problem hiding this comment.
Issue: I don't think these particular imports fit the folder structure of our site.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
useTabsto false in the prettier config, resulting in virtually every line getting formatteduseTabsset to true