Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up environment variables defined in desimodules #826

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

weaverba137
Copy link
Member

As of desihub/desimodules#52, some environment variables will be defined in desimodules.

Please wait until the PR mentioned above is merged and deployed before merging.

@weaverba137 weaverba137 self-assigned this Jul 18, 2024
@coveralls
Copy link

Coverage Status

coverage: 53.05%. remained the same
when pulling cc56675 on env-var-clean-up
into 957645b on main.

@sbailey sbailey merged commit 7a5a8cb into main Jul 19, 2024
10 of 12 checks passed
@sbailey sbailey deleted the env-var-clean-up branch July 19, 2024 16:36
@sbailey
Copy link
Contributor

sbailey commented Jul 19, 2024

FTR: I merged, updated changes.rst, reinstalled desitarget/main at NERSC, and verified that these environment variables are still set by "source desi_environment.sh main", but unlike before they are no longer unset by "module unload desitarget" (which is a good thing, because they are also needed by desispec).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants