Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightwatch docker update 202212 #319

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

sybenzvi
Copy link
Contributor

@sybenzvi sybenzvi commented Dec 8, 2022

Some docker updates to get full Nightwatch functionality working again at NERSC.

@sybenzvi sybenzvi marked this pull request as draft December 8, 2022 02:38
@sybenzvi sybenzvi added bug Something isn't working higher priority From triage of Daniel & Stephen, Jan 2021 labels Dec 8, 2022
@sybenzvi sybenzvi marked this pull request as ready for review December 11, 2022 00:26
@sybenzvi
Copy link
Contributor Author

The docker image now handles spectra properly, like the KPNO instance. A few important changes were made:

  1. Pandas is needed as a strong dependency. The missing package was causing spectrum plots to fail.
  2. desimodel and desiutil are installed with pip directly into the image, rather than mounting installations from an existing volume.

After testing on spin and updating the documentation, this should be ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working higher priority From triage of Daniel & Stephen, Jan 2021
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants