Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a model of twilight sky brightness #84

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Conversation

dkirkby
Copy link
Member

@dkirkby dkirkby commented Nov 26, 2017

We now have a functional twilight model that can be used together with the scattered moon model for more realistic bright-time simulations. The two main questions I would like to follow up on eventually are:

  • Is the spatial distribution of the predicted twilight brightness with the sun 13-15 deg below the horizon correct?
  • How should extinction affect the twilight spectrum (currently it doesn't at all).

However, I think the general features of this model are a big improvement over nothing so should be merged soon unless anyone spots obvious problems.

This PR also removes the (now obsolete) sky-conditions config parameter, which was originally to support using the gray/bright spectra in desimodel but is now redundant with the more flexible moon and twilight models.

@dkirkby
Copy link
Member Author

dkirkby commented Nov 27, 2017

Update on the two issues mentioned earlier:

  • @segasai has refit the SDSS data with a new spatial model. I'm not convinced that the new model is an improvement, but at least we know there is no easy fix here.
  • I have implemented first-order scattering (using the extinction curve) of the solar spectrum, similar to what I already implemented for scattered moonlight.

Three new plots to document the new model (which are now in the docs, along with instructions to reproduce them):

desi_moon_twilight_atmosphere

desi_twilight_polar

twilight_spectrum

@weaverba137
Copy link
Member

You'll want to bring in the latest changes from master to get tests to pass.

@moustakas
Copy link
Member

@dkirkby It would be very helpful to have this updated sky model implemented to carry out some bright-time redshift success tests, even if there's still work to be done. Can you provide any updates on when we might be able to merge this? Thanks!

@moustakas
Copy link
Member

Any chance of getting these changes into the 18.12 software release?

@weaverba137
Copy link
Member

@dkirkby, this PR is now about 3 years old. Should we continue to keep this open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants