Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ln/txn ids only #62

Merged
merged 3 commits into from
Jun 28, 2021
Merged

Ln/txn ids only #62

merged 3 commits into from
Jun 28, 2021

Conversation

lazynina
Copy link
Member

The documentation described for look up transactions for a public key and for the transaction-info endpoint explain an IDsOnly boolean that can be used to only return the TransactionBase58Check attribute of a transaction.

This resolves @carsenk's issue described here

@lazynina lazynina merged commit 749707f into main Jun 28, 2021
@lazynina lazynina deleted the ln/txn-ids-only branch June 28, 2021 20:09
@metaspartan
Copy link

@lazynina @maebeam this seems to return an empty array now with IDsOnly: true

image

@lazynina
Copy link
Member Author

@lazynina @maebeam this seems to return an empty array now with IDsOnly: true

image

I can't reproduce this behavior. It seems like your TxIndex isn't built.

@metaspartan
Copy link

@lazynina You are correct, my node isnt synced, seems to be stuck 1606 blocks out, I will redo the node

lazynina added a commit that referenced this pull request Jul 6, 2021
* Fix nil pointer error on invalid file upload

* Add lock to seed BitClout and monkey-patch blockchain.com last_price bug

* Trigger rebuild

* Trigger rebuild

* return graylist and blacklist status in get-single-profile request (#55)

* Ln/send seed bitclout (#56)

* retry sending BitClout once in the event of an error after sleeping for 5 seconds. glog the errors

* more glog

* add more details in error logs when send seed bitclout fails

* Don't use the 24h price when fetching from Blockchain.com

* Track last hour of pricing data (#59)

* keep one hours worth of last trade price history and take the max of those values

* add more comments to explain the culling logic

* add datadog logging

* [stable] Release 1.0.4

* Move github actions to buildkite

* Upgrade badgerdb

* [stable] Release 1.0.5

* rename WyreBTCAddress to BuyBitCloutBTCAddress to more accurately reflect this flag's purpose (#61)

* Ln/txn ids only (#62)

* add support for IDsOnly as described in the documentation

* only set the TransactionIdBase58Check in the Transactions slice

* omit transaction response fields if empty

* [stable] Release 1.0.6

* fix IDsOnly mempool transactions for public key (#64)

* add get nfts for user logic

Co-authored-by: maebeam <[email protected]>
Co-authored-by: diamondhands0 <[email protected]>
diamondhands0 added a commit that referenced this pull request Jul 28, 2021
* Begin adding endpoints for NFTs.

* Add endpoint to update the status of an NFT.

* Add endpoint to create an NFT bid.

* Add endpoint to accept an NFT bid.

* Add more scaffolding for NFT endpoints.

* Clean up broken endpoints.

* Fix backend to get MaxCopiesPerNFT from the GlobalParamsEntry not from the constants.

* Add IsNFT to PostEntryResponse.

* Add create-nft route.

* Add wirings for update-nft, create-nft-bid, accept-nft.

* Ln/nifties (#71)

* Fix nil pointer error on invalid file upload

* Add lock to seed BitClout and monkey-patch blockchain.com last_price bug

* Trigger rebuild

* Trigger rebuild

* return graylist and blacklist status in get-single-profile request (#55)

* Ln/send seed bitclout (#56)

* retry sending BitClout once in the event of an error after sleeping for 5 seconds. glog the errors

* more glog

* add more details in error logs when send seed bitclout fails

* Don't use the 24h price when fetching from Blockchain.com

* Track last hour of pricing data (#59)

* keep one hours worth of last trade price history and take the max of those values

* add more comments to explain the culling logic

* add datadog logging

* [stable] Release 1.0.4

* Move github actions to buildkite

* Upgrade badgerdb

* [stable] Release 1.0.5

* rename WyreBTCAddress to BuyBitCloutBTCAddress to more accurately reflect this flag's purpose (#61)

* Ln/txn ids only (#62)

* add support for IDsOnly as described in the documentation

* only set the TransactionIdBase58Check in the Transactions slice

* omit transaction response fields if empty

* [stable] Release 1.0.6

* fix IDsOnly mempool transactions for public key (#64)

* add get nfts for user logic

Co-authored-by: maebeam <[email protected]>
Co-authored-by: diamondhands0 <[email protected]>

* fix get nfts for user

* add profile entry response to nft entry response

* Add endpoints for admin management of NFT drops.

* fix profile entry response on get nfts for user endpoint

* Initial wiring of get-nft-marketplace endpoint.

* fix computation of nft creation fee, make a non-admin version of the get-global-params endpoint

* improve performance of existing endpoints by deduplicating data and omitting empty attributes, add get nft collection summary and get nft bids for user endpoints

* Add endpoint to get next NFT showcase timestamp for showcase countdown timer.

* Pass NumNFTCopiesForSale through to the frontend on the postEntry.

* add high and low bid to bid entry response to support showing whether or not this bid is currently in the lead, fix GetNFTsForUser when isForSale is nil

* add BidderBalanceNanos to bid entry response so frontend can apply logic to handle bids that can't be accepted with bidder's current balance

* Add drop entry posts to the update NFT drop endepoint.

* add GetNFTEntriesForPostHash endpoint

* use GetNFTEntriesForPostHash

* fix error text

* fix create update global params txn call in admin_transaction.go

* Improve NFT error message

Co-authored-by: redpartyhat <[email protected]>
Co-authored-by: maebeam <[email protected]>
Co-authored-by: diamondhands0 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants