Transaction testing framework #422
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ects...; add postgres support and tests for access group create txn
…cess group members txn
…action testing framework
lazynina
reviewed
Dec 6, 2022
There was a problem hiding this comment.
seems like this tests well, but it is a little confusing to go through this code. @diamondhands0 - feel free to look when you'd like to give some input here.
| // IsDependency should return true if the other input space will have overlapping utxoView/utxoOps mappings or db records | ||
| // with the current input space. This is used by the transactionTest framework to determine which transactionTestVector | ||
| // will describe entries that will be flushed to the db after both test vectors are applied. | ||
| // We assume that IsDependant is a symmetric relation, i.e. IsDependency(TV1, TV2) == IsDependency(TV2, TV1); however, |
Comment on lines
+112
to
+113
| transactionTestInputTypeAccessGroupCreate transactionTestInputType = iota | ||
| transactionTestInputTypeAccessGroupMembers |
There was a problem hiding this comment.
Is there a reason we wouldn't just re-use TxnType instead of defining a new enum we need to update whenever we add a new transaction?
| tes.testDisconnectBlock(tm, testVectorBlock) | ||
| dbEntriesAfter := tes.GetAllStateDbEntries(tm) | ||
| tes.compareBeforeAfterDbEntries(dbEntriesBefore, dbEntriesAfter) | ||
| glog.Infof(CLog(Yellow, "RunBadgerTest: successfully connected/disconnected block and verified db state")) |
There was a problem hiding this comment.
Can we set a glog level such that our builds don't have all these print statements in them please? applies to all print statements.
|
|
||
| // Fund provided public key with the desired amount of DeSo in nanos. | ||
| func (tes *transactionTestSuite) fundPublicKey(tm *transactionTestMeta, publicKey PublicKey, amountNanos uint64) { | ||
| // Note we don't need to pass Postgres here, because _doBasicTransferWithVieFlush takes it from Blockchain. |
There was a problem hiding this comment.
Suggested change
| // Note we don't need to pass Postgres here, because _doBasicTransferWithVieFlush takes it from Blockchain. | |
| // Note we don't need to pass Postgres here, because _doBasicTransferWithViewFlush takes it from Blockchain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.